LLL: macro with zero args #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good short term fix, though we should aim at removing the "literal definitions" and just keep macros. |
axic
requested changes
Jun 12, 2017
pirapira
force-pushed
the
macro_with_zero_args
branch
from
3633dfb to
f958bf1
Compare
|
I chose something more neutral. |
axic
reviewed
Jun 12, 2017
test/liblll/Parser.cpp
Outdated
| @@ -174,6 +174,12 @@ BOOST_AUTO_TEST_CASE(list) | |||
| BOOST_CHECK(!successParse("()")); | |||
| } | |||
|
|
|||
| BOOST_AUTO_TEST_CASE(macro_with_zero_args) | |||
| { | |||
| char const* text = "(def 'panic () (asm INVALID))"; | |||
There was a problem hiding this comment.
Can you change it here too for clarity? (You are right, change is not needed here.)
There was a problem hiding this comment.
No, that was me being headless chicken.
pirapira
force-pushed
the
macro_with_zero_args
branch
from
f958bf1 to
a039134
Compare
axic
reviewed
Jun 12, 2017
test/liblll/Parser.cpp
Outdated
| @@ -174,6 +174,12 @@ BOOST_AUTO_TEST_CASE(list) | |||
| BOOST_CHECK(!successParse("()")); | |||
axic
reviewed
Jun 12, 2017
test/liblll/EndToEndTest.cpp
Outdated
| char const* sourceCode = R"( | ||
| (returnlll | ||
| (seq | ||
| (def 'zeroarg () (asm INVALID)) |
There was a problem hiding this comment.
I think we should have a better test here. Such as:
(def 'zeroarg () { (mstore 0 0x1234) (return 0 32) })
|
@axic ready to merge? |
axic
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
develop, LLL macros with zero arguments were not definable because()was not a valid list.However, #2350 found a usage for that:
(panic).This PR modifies the parser so that LLL macros with zero arguments can be defined.