Avoid multiple lookups during body-copying while inlining. #15493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
force-pushed
the
bodyCopierMicroOptimization
branch
from
e491a64
to
a7233c0
Compare
cameel
reviewed
Oct 8, 2024
Comment on lines
364
to
367
| YulName BodyCopier::translateIdentifier(YulName _name) | ||
| { | ||
| if (m_variableReplacements.count(_name)) | ||
| return m_variableReplacements.at(_name); | ||
| else | ||
| return _name; | ||
| return util::valueOrDefault(m_variableReplacements, _name, _name); | ||
| } |
There was a problem hiding this comment.
It does seem to have some effect, though minimal.
Here's the time taken by BodyCopier when compiling Uniswap on 5 runs I tried:
- 2.000305 s (before)
- 1.972689 s (before)
- 1.905709 s (after)
- 1.910145 s (after)
- 1.962662 s (after)
So it's consistently lower, but the variance of the results is on the same order as the difference between them so it could very well turn out that will more runs the difference disappears.
For context, the inliner as a whole takes ~3.5 s and the whole compilation process somewhere around 110-120 s.
There was a problem hiding this comment.
Measuring BodyCopier::translateIdentifier() itself, performance concerns seem to be negligible. 2250827 calls take takes 0.008033 s in total, compared to ~120 s running time of full compilation.
|
Anything more to be done here? It's still a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.