Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMA cast support and new HW FIFO interface #586

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

DMA cast support and new HW FIFO interface #586

wants to merge 13 commits into from

Conversation

LuigiGiuffrida98
Copy link
Contributor

@LuigiGiuffrida98 LuigiGiuffrida98 commented Sep 19, 2024 •
edited
Loading

This PR includes many features and fixes (still adding):

  • When DMA is used in polling, as in the FLASH bsp, the DMA hal disables all the interrupts (bit 11 of MIE CSR) without re-enabling them, the fix prevent this to happen disabling only the DMA interrupts (bit 19 of the the MIE CSR). The DMA interrupts are still to be re-enabled at application level. @JoseCalero @JuanSapriza
  • Add setup-only functions to FLASH bsp to configure SPI and DMA independently (the DMA has to be setup and lunched manually)

@LuigiGiuffrida98 LuigiGiuffrida98 marked this pull request as ready for review October 28, 2024 12:39
@davideschiavone
Copy link
Member

@alessionaclerio22 , do not forget to update the documentation

@JuanSapriza
Copy link
Contributor

@alessionaclerio22 ToDo for HEEPidermis

@davideschiavone davideschiavone changed the title Add functionalities to flash bsp DMA cast support and new HW FIFO interface Jan 20, 2025
@davideschiavone davideschiavone changed the base branch from main to develop January 29, 2025 13:33
davidmallasen
davidmallasen requested changes Jan 29, 2025
View reviewed changes
.github/workflows/sim-apps-job/test_apps.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessionaclerio22 I missed this before, but this PR should not change how the CI tests the applications. Can you revert the changes to this file and check that the PR still passes the tests?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidmallasen I fixed the CI, but I had to blacklist the test application I developed to test the dma subaddressing mode as it uses the flash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessionaclerio22 alessionaclerio22 alessionaclerio22 left review comments

@davidmallasen davidmallasen davidmallasen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LuigiGiuffrida98 @davideschiavone @JuanSapriza @davidmallasen @alessionaclerio22