Caplin: Fix aggregate quality #12583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| var foundOverlap bool | ||
| // check the overlap bit by bit | ||
| for j := 0; j < 8; j++ { |
There was a problem hiding this comment.
So if we have two positions in both bytes where bits are 1s in both of them we return true? that's the intention right?
| @@ -160,16 +160,42 @@ func IsNonStrictSupersetBitlist(a, b []byte) bool { | |||
| return true | |||
| } | |||
|
|
|||
| func IsOverlappingBitlist(a, b []byte) bool { | |||
| // IsOverlappingSSZBitlist checks if bitlist 'a' and bitlist 'b' have any overlapping bits | |||
| // However, it ignores the last bits in the last byte. | |||
There was a problem hiding this comment.
In the last byte we check all the 8 bits. Is this correct comment?
shotasilagadze
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically we had wrong behaviour is overlapping bits. last bit on are length and shall not be counted. also decreased batched chunk size