Caplin: Fix aggregate quality (#12583)

Basically we had wrong behaviour is overlapping bits. last bit on are
length and shall not be counted. also decreased batched chunk size

cl/aggregation/pool_impl.go

@@ -77,7 +77,7 @@ func (p *aggregationPoolImpl) AddAttestation(inAtt *solid.Attestation) error {
 		return nil
 	}
 
-	if utils.IsOverlappingBitlist(att.AggregationBits.Bytes(), inAtt.AggregationBits.Bytes()) {
+	if utils.IsOverlappingSSZBitlist(att.AggregationBits.Bytes(), inAtt.AggregationBits.Bytes()) {
 		// the on bit is already set, so ignore
 		return ErrIsSuperset
 	}

cl/beacon/handler/block_production.go

@@ -1160,7 +1160,7 @@ func (a *ApiHandler) findBestAttestationsForBlockProduction(
 		candidateAggregationBits := candidate.AggregationBits.Bytes()
 		for _, curAtt := range hashToAtts[dataRoot] {
 			currAggregationBitsBytes := curAtt.AggregationBits.Bytes()
-			if !utils.IsOverlappingBitlist(currAggregationBitsBytes, candidateAggregationBits) {
+			if !utils.IsOverlappingSSZBitlist(currAggregationBitsBytes, candidateAggregationBits) {
 				// merge signatures
 				candidateSig := candidate.Signature
 				curSig := curAtt.Signature

cl/phase1/network/services/batch_signature_verification.go

@@ -12,7 +12,7 @@ import (
 )
 
 const (
-	batchSignatureVerificationThreshold = 300
+	batchSignatureVerificationThreshold = 50
 	reservedSize                        = 512
 )
 
@@ -154,7 +154,6 @@ func (b *BatchSignatureVerifier) processSignatureVerification(aggregateVerificat
 		if b.sentinel != nil && v.GossipData != nil {
 			if _, err := b.sentinel.PublishGossip(b.ctx, v.GossipData); err != nil {
 				log.Debug("failed to publish gossip", "err", err)
-				return err
 			}
 		}
 	}

cl/utils/bytes.go

@@ -160,16 +160,42 @@ func IsNonStrictSupersetBitlist(a, b []byte) bool {
 	return true
 }
 
-func IsOverlappingBitlist(a, b []byte) bool {
+// IsOverlappingSSZBitlist checks if bitlist 'a' and bitlist 'b' have any overlapping bits
+// However, it ignores the last bits in the last byte.
+func IsOverlappingSSZBitlist(a, b []byte) bool {
 	length := min(len(a), len(b))
 	for i := range length {
+
 		if a[i]&b[i] != 0 {
-			return true
+			if i != length-1 {
+				return true
+			}
+			var foundOverlap bool
+			// check the overlap bit by bit
+			for j := 0; j < 8; j++ {
+				if (a[i]>>j)&(b[i]>>j)&1 == 1 {
+					if foundOverlap {
+						return true
+					}
+					foundOverlap = true
+				}
+			}
 		}
 	}
 	return false
+
 }
 
+// func IsOverlappingBitlist(a, b []byte) bool {
+// 	length := min(len(a), len(b))
+// 	for i := range length {
+// 		if a[i]&b[i] != 0 {
+// 			return true
+// 		}
+// 	}
+// 	return false
+// }
+
 func BitsOnCount(b []byte) int {
 	count := 0
 	for _, v := range b {