Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom deploy addon support cluster addon and can select version #6446

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

polish: use constant addon name

2cef038
Select commit
Loading
Failed to load commit list.
Open

feat: custom deploy addon support cluster addon and can select version #6446

polish: use constant addon name
2cef038
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 24, 2024 in 0s

15.15% (target 10.00%)

View this Pull Request on Codecov

15.15% (target 10.00%)

Details

Codecov Report

Attention: Patch coverage is 43.85965% with 64 lines in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (9aaa584) to head (2cef038).

Files with missing lines Patch % Lines
...nternal/tools/orchestrator/services/addon/addon.go 0.00% 44 Missing ⚠️
...tools/orchestrator/services/addon/addon_handler.go 54.54% 20 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6446      +/-   ##
==========================================
+ Coverage   15.14%   15.15%   +0.01%     
==========================================
  Files        3674     3674              
  Lines      376844   376917      +73     
==========================================
+ Hits        57076    57138      +62     
- Misses     314307   314319      +12     
+ Partials     5461     5460       -1     
Files with missing lines Coverage Δ
internal/tools/orchestrator/endpoints/addon.go 6.73% <100.00%> (+3.70%) ⬆️
internal/tools/orchestrator/endpoints/endpoints.go 6.53% <100.00%> (+6.53%) ⬆️
...duler/executor/plugins/k8s/instanceinfosync/pod.go 0.00% <ø> (ø)
...tools/orchestrator/services/addon/addon_handler.go 31.79% <54.54%> (-0.16%) ⬇️
...nternal/tools/orchestrator/services/addon/addon.go 13.50% <0.00%> (-0.15%) ⬇️

... and 4 files with indirect coverage changes