feat: custom deploy addon support cluster addon and can select version #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6446 +/- ##
==========================================
+ Coverage 15.14% 15.15% +0.01%
==========================================
Files 3674 3674
Lines 376844 376917 +73
==========================================
+ Hits 57076 57138 +62
- Misses 314307 314319 +12
+ Partials 5461 5460 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: CeerDecy <[email protected]>
iutx
reviewed
Oct 23, 2024
| @@ -2686,7 +2705,7 @@ func (a *Addon) ListCustomAddon() (*[]map[string]interface{}, error) { | |||
| addonMap["addonName"] = item.Name | |||
| addonMap["vars"] = addonSpec.ConfigVars | |||
| switch item.Name { | |||
| case "mysql", "api-gateway", "monitor": | |||
| case "mysql", "api-gateway", "monitor", apistructs.AddonRegisterCenter, apistructs.AddonNewConfigCenter: | |||
There was a problem hiding this comment.
Is it possible to replace all of them with constants?
|
|
||
| if hasRegister && !hasConfig { | ||
| addonCreateReq.Addons["config-center"] = &diceyml.AddOn{ | ||
| Plan: fmt.Sprintf("%s:%s", apistructs.AddonNewConfigCenter, "basic"), |
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
feat custom deploy addon support cluster addon and can select version
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @iutx
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.