-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom deploy addon support cluster addon and can select version #6446
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6446 +/- ##
==========================================
+ Coverage 15.14% 15.15% +0.01%
==========================================
Files 3674 3674
Lines 376844 376917 +73
==========================================
+ Hits 57076 57138 +62
- Misses 314307 314319 +12
+ Partials 5461 5460 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: CeerDecy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2686,7 +2705,7 @@ func (a *Addon) ListCustomAddon() (*[]map[string]interface{}, error) { | |||
addonMap["addonName"] = item.Name | |||
addonMap["vars"] = addonSpec.ConfigVars | |||
switch item.Name { | |||
case "mysql", "api-gateway", "monitor": | |||
case "mysql", "api-gateway", "monitor", apistructs.AddonRegisterCenter, apistructs.AddonNewConfigCenter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to replace all of them with constants?
|
||
if hasRegister && !hasConfig { | ||
addonCreateReq.Addons["config-center"] = &diceyml.AddOn{ | ||
Plan: fmt.Sprintf("%s:%s", apistructs.AddonNewConfigCenter, "basic"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use constant basic
from structs.
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
What this PR does / why we need it:
feat custom deploy addon support cluster addon and can select version
Which issue(s) this PR fixes:
Specified Reviewers:
/assign @iutx
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.