Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get terminal params from args #6428

Merged
merged 8 commits into from
Sep 12, 2024

polish: use httputil consts

047e341
Select commit
Loading
Failed to load commit list.
Merged

feat: get terminal params from args #6428

polish: use httputil consts
047e341
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 12, 2024 in 0s

5.68% of diff hit (target 15.62%)

View this Pull Request on Codecov

5.68% of diff hit (target 15.62%)

Annotations

Check warning on line 322 in internal/tools/orchestrator/endpoints/instance.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/endpoints/instance.go#L322 

Added line #L322 was not covered by tests

Check warning on line 456 in internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go#L456 

Added line #L456 was not covered by tests

Check warning on line 479 in internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go#L479 

Added line #L479 was not covered by tests

Check warning on line 503 in internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go#L503 

Added line #L503 was not covered by tests

Check warning on line 615 in internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go#L615 

Added line #L615 was not covered by tests

Check warning on line 618 in internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go#L617-L618 

Added lines #L617 - L618 were not covered by tests

Check warning on line 692 in internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go#L692 

Added line #L692 was not covered by tests

Check warning on line 695 in internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go#L694-L695 

Added lines #L694 - L695 were not covered by tests

Check warning on line 122 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L122 

Added line #L122 was not covered by tests

Check warning on line 132 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L132 

Added line #L132 was not covered by tests

Check warning on line 144 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L138-L144 

Added lines #L138 - L144 were not covered by tests

Check warning on line 146 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L146 

Added line #L146 was not covered by tests

Check warning on line 155 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L148-L155 

Added lines #L148 - L155 were not covered by tests

Check warning on line 157 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L157 

Added line #L157 was not covered by tests

Check warning on line 159 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L159 

Added line #L159 was not covered by tests

Check warning on line 164 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L163-L164 

Added lines #L163 - L164 were not covered by tests

Check warning on line 168 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L167-L168 

Added lines #L167 - L168 were not covered by tests

Check warning on line 171 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L171 

Added line #L171 was not covered by tests

Check warning on line 179 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L174-L179 

Added lines #L174 - L179 were not covered by tests

Check warning on line 190 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L181-L190 

Added lines #L181 - L190 were not covered by tests

Check warning on line 193 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L192-L193 

Added lines #L192 - L193 were not covered by tests

Check warning on line 200 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L196-L200 

Added lines #L196 - L200 were not covered by tests

Check warning on line 211 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L202-L211 

Added lines #L202 - L211 were not covered by tests

Check warning on line 215 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L213-L215 

Added lines #L213 - L215 were not covered by tests

Check warning on line 222 in internal/tools/orchestrator/scheduler/impl/terminal/terminal.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/tools/orchestrator/scheduler/impl/terminal/terminal.go#L220-L222 

Added lines #L220 - L222 were not covered by tests
View more details on Codecov