Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get terminal params from args #6428

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

  1. get terminal params from args
  2. more logs in s_instance_info watcher

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English get terminal params from args and more logs in s_instance_info watcher
🇨🇳 中文 terminal参数从args中获取,并改造watcher,多输出些日志

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from iutx August 29, 2024 06:34
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 5.68182% with 83 lines in your changes missing coverage. Please review.

Project coverage is 15.61%. Comparing base (af95523) to head (047e341).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...s/orchestrator/scheduler/impl/terminal/terminal.go 0.00% 72 Missing ⚠️
...duler/executor/plugins/k8s/instanceinfosync/pod.go 0.00% 9 Missing ⚠️
internal/tools/orchestrator/endpoints/instance.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6428      +/-   ##
==========================================
- Coverage   15.62%   15.61%   -0.01%     
==========================================
  Files        3674     3674              
  Lines      311534   311571      +37     
==========================================
- Hits        48680    48666      -14     
- Misses     257398   257450      +52     
+ Partials     5456     5455       -1     
Flag Coverage Δ
by-github-actions 15.61% <5.68%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/tools/orchestrator/endpoints/instance.go 33.18% <71.42%> (+0.29%) ⬆️
...duler/executor/plugins/k8s/instanceinfosync/pod.go 0.00% <0.00%> (ø)
...s/orchestrator/scheduler/impl/terminal/terminal.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@CeerDecy
Copy link
Member Author

CeerDecy commented Aug 29, 2024

the Terminal func difficult to monkey patch, there are too many http.Request's functions

@CeerDecy CeerDecy marked this pull request as ready for review August 29, 2024 09:36
iutx
iutx previously approved these changes Sep 4, 2024
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn
New feature need frontend added params.

Copy link
Member

@sfwn sfwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need some unit tests :-)

@sfwn
Copy link
Member

sfwn commented Sep 12, 2024

/approve

@sfwn sfwn merged commit 0034b27 into erda-project:master Sep 12, 2024
22 of 23 checks passed
@sfwn
Copy link
Member

sfwn commented Sep 12, 2024

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants