-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get terminal params from args #6428
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6428 +/- ##
==========================================
- Coverage 15.62% 15.61% -0.01%
==========================================
Files 3674 3674
Lines 311534 311571 +37
==========================================
- Hits 48680 48666 -14
- Misses 257398 257450 +52
+ Partials 5456 5455 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @sfwn
New feature need frontend added params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need some unit tests :-)
internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go
Outdated
Show resolved
Hide resolved
internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go
Outdated
Show resolved
Hide resolved
internal/tools/orchestrator/scheduler/executor/plugins/k8s/instanceinfosync/pod.go
Outdated
Show resolved
Hide resolved
internal/tools/orchestrator/scheduler/impl/terminal/terminal.go
Outdated
Show resolved
Hide resolved
internal/tools/orchestrator/scheduler/impl/terminal/terminal.go
Outdated
Show resolved
Hide resolved
Signed-off-by: CeerDecy <[email protected]>
Signed-off-by: CeerDecy <[email protected]>
4e6aff6
to
408d4d9
Compare
Signed-off-by: CeerDecy <[email protected]>
408d4d9
to
047e341
Compare
/approve |
/approve |
What this PR does / why we need it:
s_instance_info
watcherWhich issue(s) this PR fixes:
Specified Reviewers:
/assign @iutx
ChangeLog
s_instance_info
watcherNeed cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0
when this PR is merged.