Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: slice replace loop #5982

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: slice replace loop #5982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions internal/tools/monitor/core/storekit/clickhouse/table/meta/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
expire := 3 * p.Cfg.ReloadInterval

var caches []MetricMeta
for _, v := range meta {
caches = append(caches, v)
}
caches = append(caches, meta...)

Check warning on line 32 in internal/tools/monitor/core/storekit/clickhouse/table/meta/cache.go

View check run for this annotation

Codecov / codecov/patch

internal/tools/monitor/core/storekit/clickhouse/table/meta/cache.go#L32 

Added line #L32 was not covered by tests

text, err := json.MarshalToString(caches)

Expand Down
48 changes: 12 additions & 36 deletions internal/tools/monitor/extensions/loghub/exporter/output_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,7 @@ func (m *MockLogger) EXPECT() *MockLoggerMockRecorder {
func (m *MockLogger) Debug(arg0 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{}
for _, a := range arg0 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg0...)
m.ctrl.Call(m, "Debug", varargs...)
}

Expand All @@ -376,9 +374,7 @@ func (mr *MockLoggerMockRecorder) Debug(arg0 ...interface{}) *gomock.Call {
func (m *MockLogger) Debugf(arg0 string, arg1 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{arg0}
for _, a := range arg1 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg1...)
m.ctrl.Call(m, "Debugf", varargs...)
}

Expand All @@ -393,9 +389,7 @@ func (mr *MockLoggerMockRecorder) Debugf(arg0 interface{}, arg1 ...interface{})
func (m *MockLogger) Error(arg0 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{}
for _, a := range arg0 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg0...)
m.ctrl.Call(m, "Error", varargs...)
}

Expand All @@ -409,9 +403,7 @@ func (mr *MockLoggerMockRecorder) Error(arg0 ...interface{}) *gomock.Call {
func (m *MockLogger) Errorf(arg0 string, arg1 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{arg0}
for _, a := range arg1 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg1...)
m.ctrl.Call(m, "Errorf", varargs...)
}

Expand All @@ -426,9 +418,7 @@ func (mr *MockLoggerMockRecorder) Errorf(arg0 interface{}, arg1 ...interface{})
func (m *MockLogger) Fatal(arg0 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{}
for _, a := range arg0 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg0...)
m.ctrl.Call(m, "Fatal", varargs...)
}

Expand All @@ -442,9 +432,7 @@ func (mr *MockLoggerMockRecorder) Fatal(arg0 ...interface{}) *gomock.Call {
func (m *MockLogger) Fatalf(arg0 string, arg1 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{arg0}
for _, a := range arg1 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg1...)
m.ctrl.Call(m, "Fatalf", varargs...)
}

Expand All @@ -459,9 +447,7 @@ func (mr *MockLoggerMockRecorder) Fatalf(arg0 interface{}, arg1 ...interface{})
func (m *MockLogger) Info(arg0 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{}
for _, a := range arg0 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg0...)
m.ctrl.Call(m, "Info", varargs...)
}

Expand All @@ -475,9 +461,7 @@ func (mr *MockLoggerMockRecorder) Info(arg0 ...interface{}) *gomock.Call {
func (m *MockLogger) Infof(arg0 string, arg1 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{arg0}
for _, a := range arg1 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg1...)
m.ctrl.Call(m, "Infof", varargs...)
}

Expand All @@ -492,9 +476,7 @@ func (mr *MockLoggerMockRecorder) Infof(arg0 interface{}, arg1 ...interface{}) *
func (m *MockLogger) Panic(arg0 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{}
for _, a := range arg0 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg0...)
m.ctrl.Call(m, "Panic", varargs...)
}

Expand All @@ -508,9 +490,7 @@ func (mr *MockLoggerMockRecorder) Panic(arg0 ...interface{}) *gomock.Call {
func (m *MockLogger) Panicf(arg0 string, arg1 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{arg0}
for _, a := range arg1 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg1...)
m.ctrl.Call(m, "Panicf", varargs...)
}

Expand Down Expand Up @@ -553,9 +533,7 @@ func (mr *MockLoggerMockRecorder) Sub(arg0 interface{}) *gomock.Call {
func (m *MockLogger) Warn(arg0 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{}
for _, a := range arg0 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg0...)
m.ctrl.Call(m, "Warn", varargs...)
}

Expand All @@ -569,9 +547,7 @@ func (mr *MockLoggerMockRecorder) Warn(arg0 ...interface{}) *gomock.Call {
func (m *MockLogger) Warnf(arg0 string, arg1 ...interface{}) {
m.ctrl.T.Helper()
varargs := []interface{}{arg0}
for _, a := range arg1 {
varargs = append(varargs, a)
}
varargs = append(varargs, arg1...)
m.ctrl.Call(m, "Warnf", varargs...)
}

Expand Down
4 changes: 1 addition & 3 deletions internal/tools/pipeline/pkg/taskerror/ordered.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@
return o
}
var ordered OrderedErrors
for _, g := range o {
ordered = append(ordered, g)
}
ordered = append(ordered, o...)

Check warning on line 45 in internal/tools/pipeline/pkg/taskerror/ordered.go

View check run for this annotation

Codecov / codecov/patch

internal/tools/pipeline/pkg/taskerror/ordered.go#L45 

Added line #L45 was not covered by tests

var newOrderedErrs OrderedErrors
now := time.Now()
Expand Down
4 changes: 1 addition & 3 deletions pkg/strutil/strutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,7 @@ func Atoi64(s string) (int64, error) {
// Map([]string{"Aa", "bB", "cc"}, ToLower, Title) => []string{"Aa", "Bb", "Cc"}
func Map(ss []string, fs ...func(s string) string) []string {
r := []string{}
for i := range ss {
r = append(r, ss[i])
}
r = append(r, ss...)
r2 := []string{}
for _, f := range fs {
for i := range r {
Expand Down
Loading