Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slice replace loop #5982

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: slice replace loop #5982

merged 1 commit into from
Jul 18, 2023

Conversation

testwill
Copy link
Contributor

What this PR does / why we need it:

slice replace loop

Which issue(s) this PR fixes:

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Specified Reviewers:

/assign @your-reviewer

ChangeLog

Language Changelog
🇺🇸 English Slice copy without for loop
🇨🇳 中文 切片拷贝不使用for循环

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@sfwn
Copy link
Member

sfwn commented Jul 18, 2023

Hi @testwill, thank you for your contribution!
Your commit needs to be signed because our repository has this requirement for commits.

@testwill
Copy link
Contributor Author

@sfwn ok

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #5982 (1fe2bd4) into master (7e7a4e3) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5982      +/-   ##
==========================================
+ Coverage   22.19%   22.20%   +0.01%     
==========================================
  Files        1880     1880              
  Lines      208480   208507      +27     
==========================================
+ Hits        46277    46308      +31     
+ Misses     156910   156902       -8     
- Partials     5293     5297       +4     
Impacted Files Coverage Δ
...nitor/core/storekit/clickhouse/table/meta/cache.go 0.00% <0.00%> (ø)
internal/tools/pipeline/pkg/taskerror/ordered.go 20.45% <0.00%> (+0.45%) ⬆️
pkg/strutil/strutil.go 71.72% <100.00%> (-0.10%) ⬇️

... and 14 files with indirect coverage changes

@sfwn
Copy link
Member

sfwn commented Jul 18, 2023

/approve

@erda-bot erda-bot merged commit a03da2e into erda-project:master Jul 18, 2023
23 checks passed
@testwill testwill deleted the loop branch July 18, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants