-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #431: Remove observation process function #439
Conversation
e320cce
to
45ea0ee
Compare
25294f9
to
9fd1c46
Compare
I think this should be good now. |
I think tolerance is a relative measure more than you think and so needs maybe some tuning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3c12848
to
c882464
Compare
c882464
to
de46d96
Compare
61b811b
to
68a3a4e
Compare
e4b607c
to
4facafc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
- Coverage 94.24% 94.09% -0.16%
==========================================
Files 16 15 -1
Lines 469 457 -12
==========================================
- Hits 442 430 -12
Misses 27 27 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
If we get this merged I can work on #430. |
Description
This PR closes #431.
It moves the mutating calls into the tests, vignettes, and sticker. It also slims them down to what is needed.
Checklist