Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on primarycensoreddist in custom family brms functions #275

Open
athowes opened this issue Sep 3, 2024 · 6 comments
Open

Depend on primarycensoreddist in custom family brms functions #275

athowes opened this issue Sep 3, 2024 · 6 comments
Assignees
Labels
low For a future release

Comments

@athowes
Copy link
Collaborator

athowes commented Sep 3, 2024

The initial version of primarycensoreddist was just made available. It is an R package which has the functions:

We should be able to use these functions to replace our implementations in posterior_predict_family and log_lik_family (I don't think for posterior_epred_family). This would reduce code duplication (we are just replacing the distribution basically in some of these functions, while copy pasting code currently).

@seabbs
Copy link
Contributor

seabbs commented Sep 3, 2024

Agree. FYi the aim is to release primarycensoreddist to CRAN by the end of next week. We should also be able to use the stan side code for a marginalised model (and the count based version of that model as well probably more interestingly

@athowes athowes added low For a future release and removed medium Nice to have for next release labels Sep 3, 2024
@athowes
Copy link
Collaborator Author

athowes commented Oct 18, 2024

Agree. FYI the aim is to release primarycensoreddist to CRAN by the end of next week.

Updates on timeline for this? From README looks like it's not on CRAN at the moment?

@seabbs
Copy link
Contributor

seabbs commented Oct 21, 2024

its not submitting tomorrow/weds

@seabbs
Copy link
Contributor

seabbs commented Oct 21, 2024

you could just depend on this via a universe and update when it hits cran but so more gated by effort to do the code changing I think

@athowes
Copy link
Collaborator Author

athowes commented Oct 21, 2024

I don't think this is urgent so from my POV happy to wait until it's on CRAN.

Unless the timeline for acceptance after submission to CRAN is weeks +?

@athowes
Copy link
Collaborator Author

athowes commented Nov 1, 2024

Flag that primarycensored is on CRAN now I think, so this can go in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low For a future release
Projects
None yet
Development

No branches or pull requests

2 participants