Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make posterior_predict_latent etc. use function factories #442

Open
seabbs opened this issue Nov 15, 2024 · 5 comments
Open

Make posterior_predict_latent etc. use function factories #442

seabbs opened this issue Nov 15, 2024 · 5 comments
Assignees

Comments

@seabbs
Copy link
Contributor

seabbs commented Nov 15, 2024

rather than requiring a function per distribution as we do now. At the same time we should update to use primarycensored vs the current custom functionality.

@seabbs seabbs added the high Required for next release label Nov 15, 2024
@seabbs seabbs self-assigned this Nov 15, 2024
@athowes
Copy link
Collaborator

athowes commented Nov 15, 2024

See #275.

@athowes
Copy link
Collaborator

athowes commented Nov 16, 2024

Comment that this is internal to the way the code works. I think the only consequence to users would be that the more general approach might mean we can relax the restriction on which families work to do predictions. In that sense I think if there are other issues that are more like "breaking" we should prioritise those.

@athowes
Copy link
Collaborator

athowes commented Nov 20, 2024

We agreed on an initial package release on 2024-11-21 (tomorrow). This is a somewhat large feature which doesn't appear to have work on it currently. I would suggest it might be future work rather than included in the release.

@seabbs
Copy link
Contributor Author

seabbs commented Nov 20, 2024

See issue442. I see this as on the critical release path as its a large feature change (going from limited to all probability distributions) and required for new models (which can share some elements (like posterior prediction)

@seabbs
Copy link
Contributor Author

seabbs commented Nov 20, 2024

I doon't mind making a small release to tick things off but I I think this needs doing before bringing in users

@athowes athowes added public release and removed high Required for next release labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants