Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not correct length of Multi-Tailed Arrow and Single arrow after loading from RDF or Layout action #2555

Closed
ivanmaslow opened this issue Oct 15, 2024 · 2 comments · Fixed by #2570
Assignees
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Oct 15, 2024

Steps to Reproduce

  1. Load 2:1:1 reaction from RDF file:
    rdf-rxn-v2000-cascade-reaction-2-1-1.zip
    image
  2. Click on Save as... and select KET format
  3. Observe the preview

Actual behavior

  • Total length of Multi-Tailed Arrow is 6.5
    • Length of tail is 0.3125
    • Length of head arrow is 6.1875
  • Total length of the single arrow is 6.5

Expected behavior

  • Total length of Multi-Tailed Arrow is 7
    • Length of tail is 0.5
    • Length of head arrow is 6.5
  • Total length of the single arrow is 7
  1. If you try to save such reaction to KET and load - the "Cannot deserialize input Json"error is displayed because tail is less than minimal size = 0.4, it will be fixed in scope of Fix minimal distances for mult-tail validation in KET format ketcher#5761
    image

Environment details:

  • RC SA env
  • [Version 2.26.0-rc.2] Build at 2024-10-14; 19:59:03
  • Indigo Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)

Additional context

@ivanmaslow ivanmaslow added Bug Priority: Medium Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Oct 15, 2024
@ivanmaslow ivanmaslow added this to the Indigo-1.25.0-rc.3 milestone Oct 15, 2024
@ivanmaslow ivanmaslow changed the title Not correct length of Multi-Tailed Arrow and Single arrow after loading from RDF Not correct length of Multi-Tailed Arrow and Single arrow after loading from RDF or Layout action Oct 15, 2024
@ivanmaslow
Copy link
Collaborator Author

ivanmaslow commented Oct 24, 2024

Pre-tested on aws_ci environment with Ketcher master and Indigo 2407-branch-ordering branches:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-24; 12:25:38;
  • Indigo Version 1.25.0-rc.3.18-gcdee98d4-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 130.0.6723.70 (Official Build) (64-bit)

The size of the Multi-Tailed Arrow and single arrow is as expected for cases with molecules, but for atoms length isn't correct:
image
There is saved ket file after loading of rdf to check sizes:
ketcher (5).zip

@ivanmaslow
Copy link
Collaborator Author

The fix is verified on RC SA env:

  • Ketcher [Version 2.26.0-rc.6] Build at 2024-10-25; 09:57:12;
  • Indigo Version 1.25.0-rc.4.0-g8862ccb7e-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome, Version 130.0.6723.70 (Official Build) (64-bit)

As mentioned in the comment above it works correctly for reactions with Molecules, but for reactions with atoms length isn't correct - the defect is reported - #2583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Projects
None yet
3 participants