Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not correct length of head arrow after loading from RDF or layout action #2453

Closed
ivanmaslow opened this issue Sep 30, 2024 · 1 comment · Fixed by #2521 or #2522
Closed

Not correct length of head arrow after loading from RDF or layout action #2453

ivanmaslow opened this issue Sep 30, 2024 · 1 comment · Fixed by #2521 or #2522
Assignees
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Sep 30, 2024

Steps to Reproduce

  1. Add a reaction with Multi-Tailed Arrow from RDF file or add it to Canvas by Tool and click on Layout action:
    head-arrow-size-issue.zip
  2. Click on save as, select ket and count the size of head arrow

Actual behavior

  • Size of head arrow is about 10.1 (x of head - x of spine):
    image

Expected behavior

  • Size of head arrow is 6.5 as mentioned in task - Update layout for pathway reaction on canvas #2309
  • Loading from RDF file should scale all the structures to the same bond length ( DEFAULT =1.6A)
    For each molecule calculate average bond length AVG - and scale each molecule by AVG/DEFAULT
    If AVG < EPS (0.01) then call layout for a molecule

Environment details

  • Detected on CI-CD environment with 2309-update-layout build
  • Ketcher [Version 2.25.0-rc.2] Build at 2024-09-30; 06:32:00
  • Version 1.25.0-dev.2.6-g0e1cfa10-wasm32-wasm-clang-12.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.71 (Official Build) (64-bit)

Notes

@ivanmaslow ivanmaslow added Bug Priority: High MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Sep 30, 2024
@ivanmaslow ivanmaslow added this to the Indigo-1.25.0-rc.1 milestone Sep 30, 2024
@ivanmaslow ivanmaslow changed the title Preview: Not correct length of head arrow after loading from RDF or layout action Not correct length of head arrow after loading from RDF or layout action Oct 4, 2024
@ivanmaslow
Copy link
Collaborator Author

Exploratory testing is completed on RC SA env:

  • [Version 2.26.0-rc.2] Build at 2024-10-14; 19:59:03
  • Indigo Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)

Length is changed, but value isn't correct, new defect is reported - #2555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: High
Projects
None yet
4 participants