Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlqs: Fix matcher-tree creation happening per filter instance #37797

Merged
merged 1 commit into from
Dec 27, 2024

Move matcher-tree creation to config.cc so that it isn't recreated wi…

bb9a277
Select commit
Loading
Failed to load commit list.
Merged

rlqs: Fix matcher-tree creation happening per filter instance #37797

Move matcher-tree creation to config.cc so that it isn't recreated wi…
bb9a277
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Publish and verify succeeded Dec 24, 2024 in 35m 9s

Envoy/Publish and verify (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Envoy/Publish and verify (pr/37797/main@bb9a277)

Check started by

Request (pr/37797/main@bb9a277)

bsurber @bsurber bb9a277 #37797 merge main@e22980c

Fix matcher-tree creation happening per filter instance

Commit Message: Move matcher-tree creation to config.cc so that it isn't recreated with every instance of the rate_limit_quota filter
Additional Description:
Risk Level:
Testing: Manual testing in-progress
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes #37534

Environment

Request variables

Key Value
ref 7b024a4
sha bb9a277
pr 37797
base-sha e22980c
actor bsurber @bsurber
message Fix matcher-tree creation happening per filter instance...
started 1735003169.902687
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f
mobile envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true