rlqs: Fix matcher-tree creation happening per filter instance #37797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th every instance of the rate_limit_quota filter Signed-off-by: Brian Surber <[email protected]>
bsurber
force-pushed
the
fix-matcher-build-rlqs
branch
from
c622a7d to
bb9a277
Compare
tyxia
reviewed
Dec 24, 2024
| if (callbacks_ != nullptr) { | ||
| data_ptr_ = std::make_unique<Http::Matching::HttpMatchingDataImpl>(callbacks_->streamInfo()); | ||
| } else { | ||
| if (!data_ptr_) { |
There was a problem hiding this comment.
i actually prefer data_ptr == nullptr style throughout this file. That is more readable for pointer type.
| } | ||
|
|
||
| return [&, config = std::move(config), config_with_hash_key, tls_store, | ||
| matcher](Http::FilterChainFactoryCallbacks& callbacks) -> void { |
There was a problem hiding this comment.
for the matcher shared pointer here, you only need to make copy (i.e., increase ref count once) once.
For example, in the RateLimitQuotaFilter constructor, it is passed by value which will achieve the need of copy above. Other places can just be move
tyxia
changed the title
|
@bsurber I will merge this PR first, could you please address the those nit comments in a follow-up PR? |
tyxia
approved these changes
Dec 27, 2024
bsurber
added a commit
to bsurber/envoy
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Brian Surber <[email protected]>
bsurber
added a commit
to bsurber/envoy
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Brian Surber <[email protected]>
tyxia
pushed a commit
that referenced
this pull request
Jan 6, 2025
Commit Message: - Nit 1: Lambda capture for the RLQS filter factory callback should move shared_ptrs instead of copying. This only saves a shared_ptr copy op per var but is still good practice. - Nit 2: Replace instances of if-conditions `(!ptr)` / `(ptr)` with `(ptr == nullptr)` / `(ptr != nullptr)` to conform to existing code. Risk Level: minimal Testing: unit testing Docs Changes: Release Notes: Platform Specific Features: Fixes commit #37797 Signed-off-by: Brian Surber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Move matcher-tree creation to config.cc so that it isn't recreated with every instance of the rate_limit_quota filter
Additional Description:
Risk Level:
Testing: Manual testing in-progress
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Fixes #37534