Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release mode NaN test failure #111

Merged
merged 1 commit into from
Feb 19, 2024
Merged

fix: release mode NaN test failure #111

merged 1 commit into from
Feb 19, 2024

Conversation

ahmedcharles
Copy link
Contributor

No description provided.

@ahmedcharles ahmedcharles requested a review from a team as a code owner February 19, 2024 02:43
@rjzak
Copy link
Member

rjzak commented Feb 19, 2024

Interesting. Out of curiosity, why is this an issue on newer Rust version?

@ahmedcharles
Copy link
Contributor Author

I assume there was an optimization change, so it might be due to a change in LLVM.

The thing that is happening seems to be that converting an f32 which has the sign bit set to an f64 doesn't result in the sign bit still being set. Either way, the representations of NaN's isn't guaranteed by Rust, so this sort of thing will happen.

@rjzak rjzak merged commit 6077683 into enarx:main Feb 19, 2024
52 of 53 checks passed
@rjzak rjzak mentioned this pull request Feb 19, 2024
Closed
2 tasks
@ahmedcharles ahmedcharles deleted the fix branch February 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzak rjzak rjzak approved these changes

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs rvolosatovs is a code owner automatically assigned from enarx/codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedcharles @rjzak