[Bug]: Unit test failing

[rjzak]

Is there an existing issue for this?

• I have searched the existing issues

Code of Conduct

• I agree to follow this project's Code of Conduct

Current Behaviour

---- codec::case_183 stdout ----
[f9, fe, 0] == [f9, fe, 0]
[f9, fe, 0] == [f9, 7e, 0]
thread 'codec::case_183' panicked at ciborium/tests/codec.rs:296:9:
assertion `left == right` failed
  left: [249, 254, 0]
 right: [249, 126, 0]

Seems to be this line case(-core::f64::NAN, val!(-core::f64::NAN), "f9fe00", false, Float), // Not In RFC in this file

ciborium/ciborium/tests/codec.rs

Lines 223 to 224 in fdf3ec5

	case(-core::f32::NAN, val!(-core::f32::NAN), "f9fe00", false, Float), // Not In RFC
	case(-core::f64::NAN, val!(-core::f64::NAN), "f9fe00", false, Float), // Not In RFC

Expected Behaviour

Test should pass

Environment Information

Github CI

What's odd that it only seems to affect release tests on Stable, Beta, and Nightly releases of Rust. Debug tests on 1.70, Stable, Beta, Nightly pass.

Steps To Reproduce

1. cargo +stable test --workspace --release

[rjzak]

Fixed in #111

[chrysn]

Reliably doing NaN payloads is a lot of manual work as long as Rust doesn't preserve them in conversion (or offers an API that converts float preserving/truncating NaN sign, signalling status and payload).

I did the full preservation rules (as described in the cde draft) in my diagnostic notation parser -- definitely no recommendation to do it precisely this way (lots of cleanup and simplifications required), just to show that it can be done, and takes fiddling with .as_bits().