test: upgrade to selenium v4

.github/workflows/maven-regression-test.yml → .github/workflows/maven-regression-test-rest.yml

@@ -1,4 +1,4 @@
-name: Maven Regression Test
+name: Maven Regression Test (REST)
 
 on:
   push:
@@ -7,7 +7,7 @@ on:
     branches: [ "main" ]
 
 jobs:
-  regression_test_ENG:
+  test_ENG:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -19,8 +19,8 @@ jobs:
       - run: mvn clean
       - run: mvn verify -P regression-testing-rest -D base.url=http://eng.elimu.ai
 
-  regression_test_TGL:
-    needs: regression_test_ENG
+  test_TGL:
+    needs: test_ENG
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -32,8 +32,8 @@ jobs:
       - run: mvn clean
       - run: mvn verify -P regression-testing-rest -D base.url=http://tgl.elimu.ai
 
-  regression_test_HIN:
-    needs: regression_test_TGL
+  test_HIN:
+    needs: test_TGL
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4

.github/workflows/maven-regression-test-ui.yml

@@ -0,0 +1,46 @@
+name: Maven Regression Test (UI)
+
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+
+jobs:
+  test_ENG:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: 17
+          cache: maven
+      - run: mvn clean
+      - run: mvn verify -P regression-testing-ui -D headless=true -D base.url=http://eng.elimu.ai
+
+  test_TGL:
+    needs: test_ENG
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: 17
+          cache: maven
+      - run: mvn clean
+      - run: mvn verify -P regression-testing-ui -D headless=true -D base.url=http://tgl.elimu.ai
+
+  test_HIN:
+    needs: test_TGL
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: 17
+          cache: maven
+      - run: mvn clean
+      - run: mvn verify -P regression-testing-ui -D headless=true -D base.url=http://hin.elimu.ai

pom.xml

@@ -575,8 +575,8 @@
         </dependency>
         <dependency>
             <groupId>org.seleniumhq.selenium</groupId>
-            <artifactId>selenium-chrome-driver</artifactId>
-            <version>3.141.59</version>
+            <artifactId>selenium-java</artifactId>
+            <version>4.23.1</version>
         </dependency>
     </dependencies>
 </project>

src/test/java/selenium/DomainHelper.java

@@ -13,7 +13,7 @@ public class DomainHelper {
     private static final Logger logger = LogManager.getLogger();
 
     public static String getBaseUrl() {
-        // Read property set on the command line: 
+        // Read "base.url" property set on the command line: 
         //    mvn clean verify -P regression-testing-rest -D base.url=https://eng.test.elimu.ai
         String baseUrlSystemProperty = System.getProperty("base.url");
         logger.info("baseUrlSystemProperty: \"" + baseUrlSystemProperty + "\"");

src/test/java/selenium/ErrorHelper.java

@@ -7,6 +7,5 @@ public class ErrorHelper {
     public static void verifyNoScriptOrMarkupError(WebDriver driver) {
         JavaScriptHelper.verifyNoJavaScriptError(driver);
 //        MarkupValidationHelper.verifyNoMarkupError(driver.getPageSource());
-        // TODO: verify no missing translations in page source ("???...???")
     }
 }

src/test/java/selenium/web/WelcomePage.java

@@ -12,7 +12,7 @@ public class WelcomePage {
     public WelcomePage(WebDriver driver) {
         this.driver = driver;
 
-        driver.findElement(By.id("welcomePageTEST"));
+        driver.findElement(By.id("welcomePage"));
 
         ErrorHelper.verifyNoScriptOrMarkupError(driver);
     }

src/test/java/selenium/web/WelcomePageTest.java

@@ -2,10 +2,13 @@
 
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.chrome.ChromeDriver;
+import org.openqa.selenium.chrome.ChromeOptions;
+
 import selenium.DomainHelper;
 
 public class WelcomePageTest {
@@ -17,13 +20,29 @@ public class WelcomePageTest {
     @BeforeEach
     public void setUp() { 
         logger.info("setUp");
+
+        ChromeOptions chromeOptions = new ChromeOptions();
+
+        // Read "headless" property set on the command line: 
+        //    mvn clean verify -P regression-testing-ui -D headless=true -D base.url=https://eng.test.elimu.ai
+        String headlessSystemProperty = System.getProperty("headless");
+        logger.info("headlessSystemProperty: \"" + headlessSystemProperty + "\"");
+        if ("true".equals(headlessSystemProperty)) {
+            chromeOptions.addArguments("headless");
+        }
 
-        // See https://www.selenium.dev/documentation/en/webdriver/driver_requirements/#chromium-chrome
-        System.setProperty("webdriver.chrome.driver", "src/test/resources/selenium/chrome_80.0.3987.106/chromedriver_mac64/chromedriver");
-        driver = new ChromeDriver();
+        driver = new ChromeDriver(chromeOptions);
+
         driver.get(DomainHelper.getBaseUrl());
     }
 
+    @AfterEach
+    public void tearDown() {
+        logger.info("tearDown");
+
+        driver.quit();
+    }
+
     @Test
     public void testWelcomePage() {
         logger.info("testWelcomePage");