test: upgrade to selenium v4 #1855
Conversation
WalkthroughThe changes encompass renaming job identifiers in existing GitHub Actions workflows to enhance clarity, introducing a new workflow for UI regression testing, and making minor modifications to Java files, including comment removals and code simplifications. Enhancements to Selenium WebDriver tests are also included to facilitate headless execution. The overall structure and functionality of the code remain unchanged while focusing on improving readability and testing processes. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1855 +/- ##
=========================================
Coverage 15.10% 15.10%
Complexity 456 456
=========================================
Files 250 250
Lines 7700 7700
Branches 804 804
=========================================
Hits 1163 1163
Misses 6487 6487
Partials 50 50 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (2)
TEST.md (2)
30-30: Add missing commas for clarity.Consider adding commas after "Then," to improve the readability of the instructions.
Apply this diff to add the commas:
- Then, in another terminal window run all the regression tests against the REST API: + Then, in another terminal window, run all the regression tests against the REST API: - Then, in another terminal window run all the regression tests against the UI: + Then, in another terminal window, run all the regression tests against the UI:Also applies to: 45-45
Tools
LanguageTool
[uncategorized] ~30-~30: A comma might be missing here.
Context: ...vn jetty:run Then, in another terminal window run all the regression tests against th...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
50-50: Avoid repetitive phrasing.The tip about setting the
base.urlsystem property is repeated. Consider rephrasing to add variety.Suggested rephrasing:
- > If you want to run the tests against another URL, set the `base.url` system property: + > To test against a different URL, specify the `base.url` system property:Tools
LanguageTool
[style] ~50-~50: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...egression-testing-ui > [!TIP] > If you want to run the tests against another URL, set ...(REP_WANT_TO_VB)
Resolves #802
Technical Details
Can be run headless by passing the
headlesssystem property.Testing Instructions
Usage examples:
mvn verify -P regression-testing-ui -D headless=true -D base.url=http://eng.elimu.aimvn verify -P regression-testing-ui -D base.url=http://eng.elimu.aimvn verify -P regression-testing-ui -D base.url=http://localhost:8080/webappScreenshots
Format Checks
Note
Files in PRs are automatically checked for format violations with
mvn spotless:check.If this PR contains files with format violations, run
mvn spotless:applyto fix them.