Fix to ESApi connector_sync_job_update_stats() to ensure undefined metadata passed as {} when undefined #3170
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield gets passed to client as {} and not None
jedrazb
reviewed
Jan 31, 2025
jedrazb
approved these changes
Jan 31, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…tadata passed as {} when undefined (#3170)
Co-authored-by: Elastic Machine <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…tadata passed as {} when undefined (#3170)
Co-authored-by: Elastic Machine <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…tadata passed as {} when undefined (#3170)
Co-authored-by: Elastic Machine <[email protected]>
mattnowzari
added a commit
that referenced
this pull request
Jan 31, 2025
…ned metadata passed as {} when undefined (#3170) (#3171)
Co-authored-by: Matt Nowzari <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
mattnowzari
added a commit
that referenced
this pull request
Jan 31, 2025
…ined metadata passed as {} when undefined (#3170) (#3172)
Co-authored-by: Matt Nowzari <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
mattnowzari
added a commit
that referenced
this pull request
Jan 31, 2025
…ned metadata passed as {} when undefined (#3170) (#3173)
Co-authored-by: Matt Nowzari <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/elastic/search-team/issues/9194
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Related Pull Requests
#3110