Fix to ESApi connector_sync_job_update_stats() to ensure undefined me…

…tadata passed as {} when undefined (#3170)

Co-authored-by: Elastic Machine <[email protected]>

connectors/es/index.py

@@ -130,7 +130,7 @@ async def connector_sync_job_update_stats(
                 self.client.connector.sync_job_update_stats,
                 connector_sync_job_id=sync_job_id,
                 body=ingestion_stats,
-                metadata=metadata,
+                metadata=metadata if metadata else {},
             )
         )
 

tests/es/test_index.py

@@ -405,7 +405,7 @@ async def test_es_api_connector_sync_job_claim():
 
 
 @pytest.mark.asyncio
-async def test_es_api_connector_sync_job_update_stats():
+async def test_es_api_connector_sync_job_update_stats_with_metadata():
     sync_job_id = "sync_job_id_test"
     ingestion_stats = {"ingestion": "stat"}
     metadata = {"meta": "data"}
@@ -418,3 +418,19 @@ async def test_es_api_connector_sync_job_update_stats():
     es_api.client.connector.sync_job_update_stats.assert_called_once_with(
         connector_sync_job_id=sync_job_id, body=ingestion_stats, metadata=metadata
     )
+
+
+@pytest.mark.asyncio
+async def test_es_api_connector_sync_job_update_stats_metadata_as_none():
+    sync_job_id = "sync_job_id_test"
+    ingestion_stats = {"ingestion": "stat"}
+    metadata = None  # make sure metadata gets passed as '{}' if undefined
+
+    es_api = ESApi(elastic_config=config)
+    es_api.client = AsyncMock()
+
+    await es_api.connector_sync_job_update_stats(sync_job_id, ingestion_stats, metadata)
+
+    es_api.client.connector.sync_job_update_stats.assert_called_once_with(
+        connector_sync_job_id=sync_job_id, body=ingestion_stats, metadata={}
+    )