Skip to content

Commit

Permalink
Merge pull request #144 from ecmwf/fix/aggregate_functions_break_bitf…
Browse files Browse the repository at this point in the history
…ields

Correctly delegate BitColumnExpression::eval(*double out, bool& missing)
  • Loading branch information
simondsmart authored Oct 23, 2024
2 parents e29a620 + 0e9a5ff commit 4550f54
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/eckit/sql/expression/BitColumnExpression.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,12 @@ class BitColumnExpression : public ColumnExpression {
// -- Overridden methods
void prepare(SQLSelect& sql) override;
void updateType(SQLSelect& sql) override;
using ColumnExpression::eval;

// Use SQLExpression's eval rather than ColumnExpression's
void eval(double* out, bool& missing) const override {
SQLExpression::eval(out, missing);
}

double eval(bool& missing) const override;
virtual void expandStars(const std::vector<std::reference_wrapper<const SQLTable>>&,
expression::Expressions&) override;
Expand Down

0 comments on commit 4550f54

Please sign in to comment.