Correctly delegate BitColumnExpression::eval(*double out, bool& missing)

In the old code calling `e.eval(&value_[0], missing_);` when e was a bitfield would actually call ColumnExpression::eval(*double out, bool& missing) and it wouldn't delegate to BitColumnExpression::eval(bool& missing) This change overrides BitColumnExpression::eval(*double out, bool& missing) to SQLExpression:eval(*double out, bool& missing) which correctly delegates to BitColumnExpression::eval(bool& missing)
ecmwf · Oct 23, 2024 · 0e9a5ff · 0e9a5ff
1 parent e29a620
commit 0e9a5ff
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/eckit/sql/expression/BitColumnExpression.h b/src/eckit/sql/expression/BitColumnExpression.h
@@ -45,7 +45,12 @@ class BitColumnExpression : public ColumnExpression {
     // -- Overridden methods
     void prepare(SQLSelect& sql) override;
     void updateType(SQLSelect& sql) override;
-    using ColumnExpression::eval;
+
+    // Use SQLExpression's eval rather than ColumnExpression's
+    void eval(double* out, bool& missing) const override {
+        SQLExpression::eval(out, missing);
+    }
+
     double eval(bool& missing) const override;
     virtual void expandStars(const std::vector<std::reference_wrapper<const SQLTable>>&,
                              expression::Expressions&) override;