Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement exploreDirectory method #84

Merged
merged 3 commits into from
Dec 23, 2023
Merged

feat: implement exploreDirectory method #84

merged 3 commits into from
Dec 23, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Dec 20, 2023

Resolves #9.

@JKRhb JKRhb force-pushed the explore-directory branch from 51fbf3f to c772824 Compare December 20, 2023 19:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (836ab1c) 53.07% compared to head (e921b65) 56.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   53.07%   56.47%   +3.39%     
==========================================
  Files          69       69              
  Lines        2210     2263      +53     
==========================================
+ Hits         1173     1278     +105     
+ Misses       1037      985      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb
Copy link
Member Author

JKRhb commented Dec 23, 2023

The tests could use some refactoring in the future, but for now, the state of this PR should be good enough for merging :)

@JKRhb JKRhb force-pushed the explore-directory branch from 06761ce to 255b2e9 Compare December 23, 2023 00:15
@JKRhb JKRhb marked this pull request as ready for review December 23, 2023 00:15
@JKRhb JKRhb enabled auto-merge December 23, 2023 00:15
@JKRhb JKRhb disabled auto-merge December 23, 2023 00:16
@JKRhb JKRhb force-pushed the explore-directory branch from 255b2e9 to e921b65 Compare December 23, 2023 00:16
@JKRhb JKRhb enabled auto-merge December 23, 2023 00:17
@JKRhb JKRhb merged commit 87003f9 into main Dec 23, 2023
4 checks passed
@JKRhb JKRhb deleted the explore-directory branch December 23, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discovery: Add support for the directory method
2 participants