Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement directory discovery #54

Closed
wants to merge 3 commits into from
Closed

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented May 13, 2023

This PR adds support for the directory discovery method to the library.

Resolves #9.

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.89 ⚠️

Comparison is base (bef2416) 60.41% compared to head (d7fe0a6) 59.52%.

❗ Current head d7fe0a6 differs from pull request most recent head 8f470e8. Consider uploading reports for the commit 8f470e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   60.41%   59.52%   -0.89%     
==========================================
  Files          70       70              
  Lines        2185     2221      +36     
==========================================
+ Hits         1320     1322       +2     
- Misses        865      899      +34     
Impacted Files Coverage Δ
lib/src/binding_coap/coap_client.dart 1.89% <0.00%> (-0.08%) ⬇️
lib/src/binding_http/http_client.dart 48.59% <ø> (-3.88%) ⬇️
lib/src/binding_mqtt/mqtt_client.dart 0.00% <ø> (ø)
lib/src/core/thing_discovery.dart 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JKRhb JKRhb force-pushed the thing-description-directory branch from d7fe0a6 to 8f470e8 Compare June 4, 2023 12:54
@JKRhb JKRhb force-pushed the thing-description-directory branch from 8f470e8 to cab9ec9 Compare July 8, 2023 16:38
@JKRhb
Copy link
Member Author

JKRhb commented Dec 20, 2023

Superseded by #84.

@JKRhb JKRhb closed this Dec 20, 2023
@JKRhb JKRhb deleted the thing-description-directory branch December 20, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discovery: Add support for the directory method
1 participant