-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature multiple loudness metadata squash tests #110
Feature multiple loudness metadata squash tests #110
Conversation
2b68021
to
f54d6cb
Compare
Codecov Report
@@ Coverage Diff @@
## 2076-2 #110 +/- ##
==========================================
- Coverage 90.78% 90.35% -0.44%
==========================================
Files 122 120 -2
Lines 5700 5557 -143
==========================================
- Hits 5175 5021 -154
- Misses 525 536 +11
Continue to review full report at Codecov.
|
If |
That makes sense, but add() then becomes a bit of a misleading name. I guess the stl equivalent would be insert_or_assign, although it's not especially catchy. |
Yeah, good point. Another alternative would be to use set/unset for things like this which are expected to be unique. As long as it's documented it's probably OK. |
4a9d2a7
to
7a44f62
Compare
6163f28
to
4e13581
Compare
only test xml loudnessMetadata in one place
4e13581
to
daeef33
Compare
fixes #84
Use generic parameter tests
Add a generic test for vector parameters
Allow a custom comparator for vector parameters (defaults to using operator==)
Fix missing unset(ContentKind) implementation