-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow multiple loudnessMetadata elements in audioProgramme and audioContent #84
Comments
We're not sure what the API of this should be. One option would be to wrap this in a class: struct LoudnessMetadatas {
using tag = ...;
std::vector<LoudnessMetadata> data;
};
audioObject.get<LoudnessMetadatas>().get();
audioObject.set(LoudnessMetadatas{std::vector<LoudnessMetadata>{...}}); ... or to just use a using LoudnessMetadatas = std::vector<LoudnessMetadata>;
audioObject.get<LoudnessMetadatas>();
audioObject.set(std::vector<LoudnessMetadata>{...}); ... or to add an API to std::shared_ptr<LoudnessMetadata> loudnessMetadata = LoudnessMetadata::create();
audioObject.add(loudnessMetadata);
audioObject.remove(loudnessMetadata);
audioObject.getLoudnessMetadata() -> std::vector<std::shared_ptr<LoudnessMetadata>> I think we both prefer option 2. |
The decision here should probably apply to #90, too |
Elsewhere in the library where there is this sort of relationship (for example |
Oh yeah! I tried to think of other cases like that, but didn't spot that one. Thanks, |
In BS.2076-2, there may be multiple
loudnessMetadata
elements inaudioProgramme
andaudioContent
; see tables 32 and 38,The text was updated successfully, but these errors were encountered: