-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send missing string for translation #5146
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on Graphite |
125feaf
to
df6bbad
Compare
7767b2f
to
da5950f
Compare
@@ -33,6 +33,8 @@ | |||
<string name="duck_player_unavailable">Duck Player Unavailable</string> | |||
<string name="duck_player_unavailable_description">Duck Player\'s functionality has been affected by recent changes to YouTube. We’re working to fix these issues and appreciate your understanding.</string> | |||
<string name="duck_player_unavailable_learn_more">Learn More</string> | |||
<!-- TODO: Remove this ignore when the translation is added --> | |||
<string name="duck_player_open_videos_setting" tools:ignore="MissingTranslation">Open YouTube Videos in Duck Player</string> | |||
<!-- TODO(cbarreiro): Add missing translations asap --> | |||
<string name="duck_player_open_in_a_new_tab_setting" tools:ignore="MissingTranslation">Open Duck Player in a new tab</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both of these ignores needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, both translations are missing in Estonian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up task: https://app.asana.com/0/0/1208558284050278/f
df6bbad
to
041af7d
Compare
Translate strings-duckplayer to values-lv
Translate strings-duckplayer to values-it
Translate strings-duckplayer to values-lt
Translate strings-duckplayer to values-fi Translate strings-duckplayer to values-pl Translate strings-duckplayer to values-sl Translate strings-duckplayer to values-da Translate strings-duckplayer to values-de Translate strings-duckplayer to values-it Translate strings-duckplayer to values-es Translate strings-duckplayer to values-lt Translate strings-duckplayer to values-sv Translate strings-duckplayer to values-tr Translate strings-duckplayer to values-pt Translate strings-duckplayer to values-lv Translate strings-duckplayer to values-hu Translate strings-duckplayer to values-fr Translate strings-duckplayer to values-hr Translate strings-duckplayer to values-ru Translate strings-duckplayer to values-nb Translate strings-duckplayer to values-sk Translate strings-duckplayer to values-bg Translate strings-duckplayer to values-ro Translate strings-duckplayer to values-cs Translate strings-duckplayer to values-nl
da5950f
to
219604d
Compare
Task/Issue URL:
Description
Note: Estonian Strings are missing due to a delay in translations. Created https://app.asana.com/0/0/1208558284050278/f as a follow up to add them when ready
Steps to test this PR
Feature 1
UI changes