Send missing string for translation #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on |
CrisBarreiro
force-pushed
the
feature/cris/duck-player/fix-yt-capitalization
branch
from
125feaf
to
df6bbad
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/missing-l10n
branch
from
7767b2f
to
da5950f
Compare
joshliebe
reviewed
Oct 17, 2024
| @@ -33,6 +33,8 @@ | |||
| <string name="duck_player_unavailable">Duck Player Unavailable</string> | |||
| <string name="duck_player_unavailable_description">Duck Player\'s functionality has been affected by recent changes to YouTube. We’re working to fix these issues and appreciate your understanding.</string> | |||
| <string name="duck_player_unavailable_learn_more">Learn More</string> | |||
| <!-- TODO: Remove this ignore when the translation is added --> | |||
| <string name="duck_player_open_videos_setting" tools:ignore="MissingTranslation">Open YouTube Videos in Duck Player</string> | |||
| <!-- TODO(cbarreiro): Add missing translations asap --> | |||
| <string name="duck_player_open_in_a_new_tab_setting" tools:ignore="MissingTranslation">Open Duck Player in a new tab</string> | |||
There was a problem hiding this comment.
Are both of these ignores needed?
There was a problem hiding this comment.
Yes, both translations are missing in Estonian
There was a problem hiding this comment.
Follow-up task: https://app.asana.com/0/0/1208558284050278/f
joshliebe
approved these changes
Oct 17, 2024
CrisBarreiro
force-pushed
the
feature/cris/duck-player/fix-yt-capitalization
branch
from
df6bbad
to
041af7d
Compare
Base automatically changed from
feature/cris/duck-player/fix-yt-capitalization
to
develop
October 17, 2024 19:05
Translate strings-duckplayer to values-lv
Translate strings-duckplayer to values-it
Translate strings-duckplayer to values-lt
Translate strings-duckplayer to values-fi Translate strings-duckplayer to values-pl Translate strings-duckplayer to values-sl Translate strings-duckplayer to values-da Translate strings-duckplayer to values-de Translate strings-duckplayer to values-it Translate strings-duckplayer to values-es Translate strings-duckplayer to values-lt Translate strings-duckplayer to values-sv Translate strings-duckplayer to values-tr Translate strings-duckplayer to values-pt Translate strings-duckplayer to values-lv Translate strings-duckplayer to values-hu Translate strings-duckplayer to values-fr Translate strings-duckplayer to values-hr Translate strings-duckplayer to values-ru Translate strings-duckplayer to values-nb Translate strings-duckplayer to values-sk Translate strings-duckplayer to values-bg Translate strings-duckplayer to values-ro Translate strings-duckplayer to values-cs Translate strings-duckplayer to values-nl
CrisBarreiro
force-pushed
the
feature/cris/duck-player/missing-l10n
branch
from
da5950f
to
219604d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Description
Note: Estonian Strings are missing due to a delay in translations. Created https://app.asana.com/0/0/1208558284050278/f as a follow up to add them when ready
Steps to test this PR
Feature 1
UI changes