Add pixels for open in new tab #5125
Merged
+60
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on |
3 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on |
joshliebe
reviewed
Oct 10, 2024
duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/impl/RealDuckPlayer.kt
Show resolved
Hide resolved
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-ff
branch
from
7b75e44
to
c103f17
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-pixels
branch
from
c99ff33
to
8ed9271
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-ff
branch
from
c103f17
to
5f6497e
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-pixels
branch
from
8ed9271
to
995d7fd
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-ff
branch
from
5f6497e
to
1912aef
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-pixels
branch
3 times, most recently
from
c0c88b1
to
6625708
Compare
joshliebe
approved these changes
Oct 16, 2024
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-ff
branch
from
8a2d45c
to
41cd61d
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-pixels
branch
from
6625708
to
77c2e2f
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-ff
branch
from
41cd61d
to
03c1c3d
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-pixels
branch
from
77c2e2f
to
02f973e
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-ff
branch
from
03c1c3d
to
0a30637
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-pixels
branch
from
02f973e
to
84dd898
Compare
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-ff
branch
from
0a30637
to
165362d
Compare
Base automatically changed from
feature/cris/duck-player/open-new-tab-ff
to
develop
October 17, 2024 18:18
CrisBarreiro
force-pushed
the
feature/cris/duck-player/open-new-tab-pixels
branch
from
84dd898
to
f11f242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1142021229838617/1208511584623405/f
Description
Steps to test this PR
Feature 1
duckplayer_newtab_setting-onandduckplayer_newtab_setting-offare sentFeature 2
duckplayer_daily-unique-viewis sent (or skipped if not the first time in the day) with params "newtab" to true or false depending on the open in new tab settingsUI changes