-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixels for open in new tab #5125
Add pixels for open in new tab #5125
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on Graphite |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on Graphite |
duckplayer/duckplayer-impl/src/main/java/com/duckduckgo/duckplayer/impl/RealDuckPlayer.kt
Show resolved
Hide resolved
7b75e44
to
c103f17
Compare
c99ff33
to
8ed9271
Compare
c103f17
to
5f6497e
Compare
8ed9271
to
995d7fd
Compare
5f6497e
to
1912aef
Compare
c0c88b1
to
6625708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, LGTM!
8a2d45c
to
41cd61d
Compare
6625708
to
77c2e2f
Compare
41cd61d
to
03c1c3d
Compare
77c2e2f
to
02f973e
Compare
03c1c3d
to
0a30637
Compare
02f973e
to
84dd898
Compare
0a30637
to
165362d
Compare
84dd898
to
f11f242
Compare
Task/Issue URL: https://app.asana.com/0/1142021229838617/1208511584623405/f
Description
Steps to test this PR
Feature 1
duckplayer_newtab_setting-on
andduckplayer_newtab_setting-off
are sentFeature 2
duckplayer_daily-unique-view
is sent (or skipped if not the first time in the day) with params "newtab" to true or false depending on the open in new tab settingsUI changes