Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull to refresh when the error screen is shown #4006

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Dec 14, 2023

Task/Issue URL: https://app.asana.com/0/1202552961248957/1205928683641648/f

Description

This PR adds pull to refresh when the error screen is shown. Fixes #3801

Steps to test this PR

  • Go to any website
  • Put the phone in airplane mode
  • Refresh the website, yeti screen should shown
  • Pull to refresh should be possible
  • Remove airplane mode and use pull to refresh, website should be visible again

@marcosholgado
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@CDRussell CDRussell self-assigned this Dec 15, 2023
@CDRussell
Copy link
Member

CDRussell commented Dec 15, 2023

Not sure if this is new, but the P2R sometimes gets stuck and doesn't disappear when there's no internet connection (stays spinning forever), and doesn't disappear if you try navigate to another page. Don't think it's a blocker, but flagging in case there's an easy fix.

(example uploaded to linked task)

Base automatically changed from feature/marcos/remove_errors_refresh to develop December 15, 2023 14:45
@marcosholgado marcosholgado merged commit 9bd533b into develop Dec 15, 2023
6 checks passed
@marcosholgado marcosholgado deleted the feature/marcos/error_pull_refresh branch December 15, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] No reload gesture on "this page cant be loaded" page
2 participants