Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes errors after a manual refresh #4004

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

marcosholgado
Copy link
Contributor

@marcosholgado marcosholgado commented Dec 14, 2023

Task/Issue URL: https://app.asana.com/0/414730916066338/1206139108436193/f

Description

This task removes errors from a site after a manual refresh has been triggered. It also fixes the yeti screen stuck even after a successul refresh of the page. It doesn't add the pull to refresh capability though. Comming soon.

Steps to test this PR

  • Go to www.pacopatata.es
  • Web shouldn't load
  • Filter logcat by epbf
  • Send a broken site report
  • Pixel should contain an errorDescription
  • Now go to https://client-cert-missing.badssl.com/
  • Send a broken site report
  • Pixel should not have an errorDescription but an httpErrorCode instead.
  • Go to cnn.com
  • Put the phone in airplane mode and refresh
  • You should see the yeti screen
  • Send a broken site report
  • Pixel should have an errorDescription
  • Remove airplane mode and refresh the page
  • Yeti screen should disappear
  • Send a broken site report
  • Pixel should not contain an errorDescription or httpErrorCode

@marcosholgado
Copy link
Contributor Author

marcosholgado commented Dec 14, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@marcosholgado marcosholgado merged commit 0700f71 into develop Dec 15, 2023
7 checks passed
@marcosholgado marcosholgado deleted the feature/marcos/remove_errors_refresh branch December 15, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants