Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2741 running metplus #2801

Merged
merged 27 commits into from
Nov 20, 2024
Merged

Feature 2741 running metplus #2801

merged 27 commits into from
Nov 20, 2024

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented Nov 19, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    This portion of the pull request cleaned up the "Running METplus" Use Case section.
  1. I cleaned up the extraneous language and matched the text to the Use Case Template.
  2. I removed any instance of "-c " which is no longer an applicable command. These were found by running the command, "find . -name "*.py" | xargs egrep -n "-c " | more" in the model_applications folder. Please note that @CPKalb is working on the majority of the s2s Use Cases and are not included with this pull request.
  3. Please note, in some cases the "-c" was found in the METplus Configuration section. I removed the "-c" and did my best to update the language to the template.
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    This task was straightforward to complete. Please review for anything I might have overlooked. There are no questions for review on the spreadsheet. Here is a link to the web pages. I think I got all of the commas, but feel free to double check.

DO NOT CLOSE THIS ISSUE when the pull request is completed. There is more work to be done on this issue.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [11/22/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@lisagoodrich lisagoodrich added this to the METplus-6.1.0 milestone Nov 19, 2024
@lisagoodrich lisagoodrich linked an issue Nov 19, 2024 that may be closed by this pull request
24 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your work on this task @lisagoodrich. Looks good! I'll go ahead approve and Squash and Merge. I will leave the branch alone for now and will also leave the issue open.

@jprestop jprestop merged commit 2b54612 into develop Nov 20, 2024
2 of 3 checks passed
@jprestop jprestop deleted the feature_2741_running_metplus branch November 20, 2024 18:17
@lisagoodrich
Copy link
Contributor Author

@jprestop thank you so much for explaining why and what needed to be changed. I've removed all of the "literalinclude: bash" references. I think it's good to go. Let me know if you find other problems. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Documentation: Update existing use cases to use the template
2 participants