-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2741 running metplus #2801
Conversation
…Tplus into feature_2741_running_metplus
…41_running_metplus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work on this task @lisagoodrich. Looks good! I'll go ahead approve and Squash and Merge. I will leave the branch alone for now and will also leave the issue open.
@jprestop thank you so much for explaining why and what needed to be changed. I've removed all of the "literalinclude: bash" references. I think it's good to go. Let me know if you find other problems. Thanks! |
Pull Request Testing
This portion of the pull request cleaned up the "Running METplus" Use Case section.
This task was straightforward to complete. Please review for anything I might have overlooked. There are no questions for review on the spreadsheet. Here is a link to the web pages. I think I got all of the commas, but feel free to double check.
DO NOT CLOSE THIS ISSUE when the pull request is completed. There is more work to be done on this issue.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [11/22/24].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases