Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update existing use cases to use the template #2741

Open
9 of 24 tasks
jprestop opened this issue Oct 22, 2024 · 5 comments · Fixed by #2793, #2801 or #2808
Open
9 of 24 tasks

Documentation: Update existing use cases to use the template #2741

jprestop opened this issue Oct 22, 2024 · 5 comments · Fixed by #2793, #2801 or #2808
Assignees
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: documentation Documentation issue priority: high High Priority reporting: NRL METplus Naval Research Laboratory METplus Project requestor: Navy/NRL Naval Research Laboratory type: enhancement Improve something that it is currently doing
Milestone

Comments

@jprestop
Copy link
Collaborator

jprestop commented Oct 22, 2024

Describe the Enhancement

In the METplus-6.0.0-beta6 release cycle the following issue was created and completed:
Documentation: Develop an RST template for use cases #918
The templates have been developed and now we need to update all existing use cases to utilize the templates.

@CPKalb has already started on using the new templates for some of the existing templates.

See Tina's comment on this issue regarding what she is working on.

@lisagoodrich I talked with Dan about how to get started on this task. First we'll start with a spreadsheet identifying what cases we have and which fields need to be changed. We'll talk about all of this before you get started.

Time Estimate

??

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

The current funding for this work ends on 12/31/2024.

Funding Source

7730022

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplus-Wrappers-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplus-Wrappers-X.Y.Z version, select the METplus-Wrappers-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@jprestop jprestop added type: enhancement Improve something that it is currently doing component: documentation Documentation issue priority: high High Priority requestor: Navy/NRL Naval Research Laboratory alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle reporting: NRL METplus Naval Research Laboratory METplus Project labels Oct 22, 2024
@jprestop jprestop added this to the METplus-6.1.0 milestone Oct 22, 2024
@CPKalb
Copy link
Contributor

CPKalb commented Oct 22, 2024

@lisagoodrich, @jprestop

The ones I have been working on are part of issue 2628. While I'm updating the scientific objective, I am also moving them to the new template. The use cases include:

s2s_mid_lat:
UserScript_fcstGFS_obsERA_Blocking
UserScript_obsERA_obsOnly_Blocking
UserScript_fcstGFS_obsERA_WeatherRegime
UserScript_obsERA_obsOnly_WeatherRegime

s2s_mjo:
UserScript_fcstGFS_obsERA_OMI
UserScript_obsERA_obsOnly_OMI
UserScript_obsERA_obsOnly_RMM
UserScript_obsERA_obsOnly_PhaseDiagram

s2s_stratosphere:
UserScript_fcstGFS_obsERA_StratosphereBias
UserScript_fcstGFS_obsERA_StratospherePolar
UserScript_fcstGFS_obsERA_StratosphereQBO

This is basically all the use cases in s2s_mid_lat and s2s_stratosphere, but there are others in the s2s_mjo area that are not part of that issue. Let me know if you you want me to just do all the s2s_mjo use cases...

The s2s_mid_lat and s2s_mjo use cases are done and I still need to finish up the stratosphere ones. I'll do that under issue 2628 since I've already been working there.

@jprestop
Copy link
Collaborator Author

@CPKalb Thank you so much for this helpful information! I really appreciate you taking the time so quickly to list these cases here.

@CPKalb
Copy link
Contributor

CPKalb commented Oct 22, 2024

@jprestop, it looks like the updated documentation has a section for "Version Added." If we are unsure which version of METplus a use case was added, is there a way to get this information?

@jprestop
Copy link
Collaborator Author

@jprestop, it looks like the updated documentation has a section for "Version Added." If we are unsure which version of METplus a use case was added, is there a way to get this information?

@CPKalb That is a great question. I tried to look this up via google, but my search strings were not producing the results I was looking for.

In looking for the version where UserScript_fcstGFS_obsERA_Blocking was added, I believe I was able to find this information. Here are the steps I took (see video of me walking through it):

  • Navigate to the use case in the repository (in this case develop/docs/use_cases/model_applications/s2s_mid_lat/UserScript_fcstGFS_obsERA_Blocking.py)
  • Click on "Blame"
  • Scroll down to the bottom and look at the left hand column to find the earliest feature number associated with this file
  • Look up that closed issue in the respository
  • Ensure that it does have to do with the creation of this use case
  • Look at the milestone assigned to it

I'm wondering if @JohnHalleyGotway knows of a more straightforward way to get this information. The method I have found here is time consuming and if the milestone wasn't selected, it could prove to be more difficult to figure out.

@georgemccabe
Copy link
Collaborator

@jprestop, I did something similar to get this information.

You can also click on the use case doc file, then click on "History" and scroll to the earliest commit to see when it was added. In this case, the file was renamed, but there is a link to see the history before the rename (click "Browse History"). From there, I see the earliest commit was from PR #856, so I clicked on the link to navigate to that PR. From there I can see that it was added for Milestone 4.0.0.

Screen.Recording.2024-10-23.at.1.07.58.PM.mov

jprestop added a commit that referenced this issue Nov 11, 2024
@lisagoodrich lisagoodrich linked a pull request Nov 14, 2024 that will close this issue
16 tasks
jprestop added a commit that referenced this issue Nov 18, 2024
* updating template first pass

* removing backslash

* removing extra # symbol

* removing spaces.  Keep as is

* removing spaces for consistency

* adding changes to match template

* fixing spacing

* fixing spacing take 2

* Per #2741, correcting typo in OUPUT_BASE in template file

* Per #2741, correcting typo in OUPUT_BASE

* Per #2741, updating sections based on template and template description

* Updated language in several sections, needs additional work on output and config file

* updating for consistency

* Updating file based on suggestions from George

* Updating with suggestions from George

* Updating file based on suggestions from George

* reviewing with Julie

* Per #2741 attempting to resolve errors

* Per #2741, updating template to fix rendering problems

* Per #2741, fixing formatting

* Per #2741 attempting to resolve warnings

* Per #2741, resolving error

* Resolving formatting problems with template

* Fixing formatting problems

* updating for consistency

* fixing formatting

* removing extra spaces

* Updating formatting

* updating for consistency

* adding METplus Workflow times

* modifications

* Update GridStat_fcstCESM_obsGFS_ConusTemp.py

Added some information to the use case

* Update MODE_fcstCESM_obsGPCP_AsianMonsoonPrecip.py

Updates

* Added an extra blank line

* updating for consistency

* fixing spacing

* adding space

* removing Update content

* updating for consistency

* adding a period

* updating for consistency

* updating for consistency

* updating for consistency

* updating for consistency

* adding return

* replacing underlines

* replacing return?

* fixing blank line

* more attempts to fix warnings

* updating for consistency

* adding double colons and stuff

* trying stuff

* trying extra spacing

* Changing Datasets Location info to match template

* Per #2741, updating formatting and wording

* Per #2741, updating after reviewing

* Per #2741, attempting to resolve errors

* updating for consistency

* fixing brackets and section breaks

* adding return

* Per #2741, updating after reviewing

* updating for consistency

* fixing spacing

* adding a pound

* Updating wording for User Scripting

* Updating the text for User Scripting

* Updating User Script section

* Updating text for User Scripting

* Updating text

* adding location information

* adding location information

* updated first cloud file, will use for remaining cloud use cases

* updated language in numerous use case doc files

* updated final marine use case

---------

Co-authored-by: Julie Prestopnik <[email protected]>
Co-authored-by: j-opatz <[email protected]>
Co-authored-by: Christina Kalb <[email protected]>
Co-authored-by: j-opatz <[email protected]>
This was linked to pull requests Nov 19, 2024
jprestop added a commit that referenced this issue Dec 3, 2024
lisagoodrich added a commit that referenced this issue Dec 10, 2024
* marine_and_cryosphere directories

* fixing underlining

* trying to fix warning msg.

* trying to fix warning msg. again

* Removing space before i.e.

* updating medium_range and pbl directories

* deleting empty file

* removing lots of old text

* precipitation files

* removing junk file

* removing extra #

* add return

* updating 3 dirs s2s, space_weather and unstructured_grids

* updating short_range files

* adding tc_and_extra_tc files

* removing defunct -c option

* added dropdown menus for marine_and_cryosphere

* fixing problems and dropdowns for medium_range

* fixing new problems

* dropdowns for pbl and precip

* adding double colons

* Attempting to resolve errors

* dropdowns for s2s and s2s_mjo

* adding dropdowns for short_range files

* final dropdown directories

* Update docs/use_cases/model_applications/marine_and_cryosphere/GridStat_fcstRTOFS_obsGHRSST_climWOA_sst.py

removing note

Co-authored-by: Julie Prestopnik <[email protected]>

* Apply suggestions from code review

adding all of the suggestions

Co-authored-by: Julie Prestopnik <[email protected]>

* Update GridStat_fcstRTOFS_obsGHRSST_climWOA_sst.py

ensuring literal include is in dropdown menu

* Update GridStat_fcstRTOFS_obsOSTIA_iceCover.py

ensuring literal include is in dropdown

* ensuring literal include is in dropdown menu

* marine_and_cryosphere MET Configuration dropdown fixes

* remaining dropdown directories for MET Configuration

* Julie changing dropdowns

Co-authored-by: Julie Prestopnik <[email protected]>

* HEAD needed to be removed

* There are not MET tools used in this use case

* There are no MET tools used in this use case

* Apply suggestions from code review

Co-authored-by: Julie Prestopnik <[email protected]>

* Per #2741, few small changes

* updates from pull request discussion

* removing space

Co-authored-by: Julie Prestopnik <[email protected]>

* fixing dropdown

Co-authored-by: Julie Prestopnik <[email protected]>

* removing bash

Co-authored-by: Julie Prestopnik <[email protected]>

* update from Julie

Co-authored-by: Julie Prestopnik <[email protected]>

* Fixing error

* lots of typos

Co-authored-by: Julie Prestopnik <[email protected]>

* Adding period

* Adding colon

* Added period

* Added period

* Added period

* typos and more

Co-authored-by: Julie Prestopnik <[email protected]>

---------

Co-authored-by: Julie Prestopnik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle component: documentation Documentation issue priority: high High Priority reporting: NRL METplus Naval Research Laboratory METplus Project requestor: Navy/NRL Naval Research Laboratory type: enhancement Improve something that it is currently doing
Projects
Status: 🏗 In progress
4 participants