Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2741 dropdowns #2808

Merged
merged 60 commits into from
Dec 10, 2024
Merged

Feature 2741 dropdowns #2808

merged 60 commits into from
Dec 10, 2024

Conversation

lisagoodrich
Copy link
Contributor

@lisagoodrich lisagoodrich commented Nov 22, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Dropdown menus were added for:
    MET Configuration
    Python Embedding
    User Scripting
    Other general clean up of language, formatting and punctuation was also included for these sections of Use Case documentation.

I also tried to find "master_metplus" mentions in the documentation but I'm not sure the below command is correct. I couldn't get it to work for "run_metplus". Please feel free correct the command and I'll fix this. I ran this while in the model_applications folder.
find . -name /".py" | xargs egrep -n "master_metplus" | more

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Apologies @jprestop, we discussed doing more work under this branch but I made the executive decision to just include the dropdowns in this pull request. There is a lot of material to review. This was a natural stopping point and this will keep the pull request to a reasonable amount of work. I was nervous about the pull request sitting around for a week and not being up to date with develop, but since next week is a holiday week, I'm hoping it will be fine.

Please see the spreadsheet and the highlights in blue under the MET Configuration, Python Embedding and User Scripting columns for questions and concerns I had on specific issues. If you'd like to look at the dropdowns in action on the web site they can be viewed here.

Please review the material for any inconsistencies in formatting or language.

I have scoured my emails but I can't find the information about the language in the User Scripting section. I have a vague recollection that some of these early sections may have different language. It should say, "User Scripting is not used in this use case." I don't remember the different sentence. I was going to search for the sentence that needs to be changed, but I don't know what that is because I can't find your email. Please feel free to kick this back to me and I'll make these updates before you do the review.

DO NOT CLOSE THE ISSUE when this is completed. There is more work to be done under this issue. Thanks.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [12/4/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

lisagoodrich and others added 30 commits November 14, 2024 16:17
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lisagoodrich. I decided I should take a quick glance at all of the files in RTD. In doing that, I found a few other things that needed corrections, so I noted those here. Thanks for your patience and your work on this task!

Co-authored-by: Julie Prestopnik <[email protected]>
@lisagoodrich
Copy link
Contributor Author

Hi @jprestop thanks for catching all of those typos! I'm not sure, are we ready to commit this branch?

@jprestop
Copy link
Collaborator

jprestop commented Dec 9, 2024

Hi @lisagoodrich. I went back through RTD and found a few other things. Once those are updated, I'll go ahead and approve and we can get this merged in. Thanks for your patience and all of your hard work!

Co-authored-by: Julie Prestopnik <[email protected]>
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lisagoodrich Thanks again for iterating with me and for all of your work on this task. I approve. I'll let you squash and merge this branch when you're ready and you can decide if you need to keep or delete the branch.

@lisagoodrich lisagoodrich merged commit 75476cd into develop Dec 10, 2024
3 checks passed
@lisagoodrich lisagoodrich deleted the feature_2741_dropdowns branch December 10, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Documentation: Update existing use cases to use the template
4 participants