-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2741 dropdowns #2808
Feature 2741 dropdowns #2808
Conversation
…Tplus into feature_2741_running_metplus
…41_running_metplus
…41_running_metplus
docs/use_cases/model_applications/pbl/PointStat_fcstHRRR_obsAMDAR_PBLH_PyEmbed.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/pbl/PointStat_fcstHRRR_obsAMDAR_PBLH_PyEmbed.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/precipitation/GenEnsProd_fcstHRRRE_FcstOnly_NetCDF.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/precipitation/PointStat_fcstURMA_obsCOCORAHS_ASCIIprecip.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/precipitation/PointStat_fcstURMA_obsCOCORAHS_ASCIIprecip.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/s2s/UserScript_fcstS2S_obsERAI_CrossSpectra.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/s2s/TCGen_fcstGFSO_obsBDECKS_GDF_TDF.py
Outdated
Show resolved
Hide resolved
...ations/short_range/UserScript_fcstRRFS_fcstOnly_Reformat_Aggregate_Plot_ecnt_spread_skill.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lisagoodrich. I decided I should take a quick glance at all of the files in RTD. In doing that, I found a few other things that needed corrections, so I noted those here. Thanks for your patience and your work on this task!
Co-authored-by: Julie Prestopnik <[email protected]>
Hi @jprestop thanks for catching all of those typos! I'm not sure, are we ready to commit this branch? |
...ases/model_applications/marine_and_cryosphere/PointStat_fcstRTOFS_obsARGO_climoWOA23_temp.py
Outdated
Show resolved
Hide resolved
..._cases/model_applications/marine_and_cryosphere/PointStat_fcstGFS_obsASCAT_satelliteWinds.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/marine_and_cryosphere/PlotDataPlane_obsHYCOM_coordTripolar.py
Outdated
Show resolved
Hide resolved
...s/model_applications/marine_and_cryosphere/PointStat_fcstGFS_obsJASON3_satelliteAltimetry.py
Outdated
Show resolved
Hide resolved
...use_cases/model_applications/marine_and_cryosphere/GridStat_fcstRTOFS_obsSMAP_climWOA_sss.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/medium_range/UserScript_fcstGEFS_Difficulty_Index.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/s2s_mjo/UserScript_obsCFSR_obsOnly_MJO_ENSO.py
Outdated
Show resolved
Hide resolved
docs/use_cases/model_applications/short_range/Point2Grid_obsLSR_ObsOnly_PracticallyPerfect.py
Outdated
Show resolved
Hide resolved
Hi @lisagoodrich. I went back through RTD and found a few other things. Once those are updated, I'll go ahead and approve and we can get this merged in. Thanks for your patience and all of your hard work! |
Co-authored-by: Julie Prestopnik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lisagoodrich Thanks again for iterating with me and for all of your work on this task. I approve. I'll let you squash and merge this branch when you're ready and you can decide if you need to keep or delete the branch.
Pull Request Testing
Dropdown menus were added for:
MET Configuration
Python Embedding
User Scripting
Other general clean up of language, formatting and punctuation was also included for these sections of Use Case documentation.
I also tried to find "master_metplus" mentions in the documentation but I'm not sure the below command is correct. I couldn't get it to work for "run_metplus". Please feel free correct the command and I'll fix this. I ran this while in the model_applications folder.
find . -name /".py" | xargs egrep -n "master_metplus" | more
Apologies @jprestop, we discussed doing more work under this branch but I made the executive decision to just include the dropdowns in this pull request. There is a lot of material to review. This was a natural stopping point and this will keep the pull request to a reasonable amount of work. I was nervous about the pull request sitting around for a week and not being up to date with develop, but since next week is a holiday week, I'm hoping it will be fine.
Please see the spreadsheet and the highlights in blue under the MET Configuration, Python Embedding and User Scripting columns for questions and concerns I had on specific issues. If you'd like to look at the dropdowns in action on the web site they can be viewed here.
Please review the material for any inconsistencies in formatting or language.
I have scoured my emails but I can't find the information about the language in the User Scripting section. I have a vague recollection that some of these early sections may have different language. It should say, "User Scripting is not used in this use case." I don't remember the different sentence. I was going to search for the sentence that needs to be changed, but I don't know what that is because I can't find your email. Please feel free to kick this back to me and I'll make these updates before you do the review.
DO NOT CLOSE THE ISSUE when this is completed. There is more work to be done under this issue. Thanks.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [12/4/24].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases