Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2742 develop fix StatAnalysis to set fcst_lev/obs_lev #2760

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

georgemccabe
Copy link
Collaborator

instead of fcst_level/obs_level to match actual MET config variable names. Added unit tests to ensure correct behavior occurs

Pull Request Testing

  • Describe testing already performed for these changes:

Added tests then fixed the code to make them pass

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review code changes, ensure all automated tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 11/1/2024.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…st_level and obs_level to match actual MET config variable names. Added unit tests to ensure correct behavior occurs
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same approach for the develop branch that's used for the main_v5.1 bugfix. Keep all the config options the same in METplus, just replace instances of _level with _lev.

I did check the docs for FCST_LEVEL_LIST and OBS_LEVEL_LIST and confirmed that they correctly state that they're used to set FCST_LEV and OBS_LEV columns of the MET output. So the documentation is already correct.

I approve.

@georgemccabe georgemccabe merged commit 258d27d into develop Nov 1, 2024
75 checks passed
@georgemccabe georgemccabe deleted the feature_2742_develop_stat_analysis_level branch November 1, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix StatAnalysis to set fcst_lev config variable instead of fcst_level
2 participants