Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix StatAnalysis to set fcst_lev config variable instead of fcst_level #2742

Closed
24 tasks
georgemccabe opened this issue Oct 23, 2024 · 0 comments · Fixed by #2760 or #2761
Closed
24 tasks

Bugfix: Fix StatAnalysis to set fcst_lev config variable instead of fcst_level #2742

georgemccabe opened this issue Oct 23, 2024 · 0 comments · Fixed by #2760 or #2761
Assignees
Labels
priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: bug Fix something that is not working

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Oct 23, 2024

This was discovered in discussion #2734.

Describe the Problem

StatAnalysis wrapper sets the fcst_level and obs_level MET config variables. However, the actual MET config variables are named fcst_lev and obs_lev.

Expected Behavior

Setting values in FCST_LEVEL_LIST or OBS_LEVEL_LIST should properly set the value of METPLUS_FCST_LEVEL and METPLUS_OBS_LEVEL to fcst_lev = <VALUE>; and obs_lev = <VALUE>; respectively.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7750034

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select METplus-Wrappers-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.

  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>

  • Fix the bug and test your changes.

  • Add/update log messages for easier debugging.

  • Add/update unit tests.

  • Add/update documentation.

  • Add any new Python packages to the METplus Components Python Requirements table.

  • Push local changes to GitHub.

  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>

  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release

  • Iterate until the reviewer(s) accept and merge your changes.

  • Delete your fork or branch.

  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release

  • Close this issue.

@georgemccabe georgemccabe added type: bug Fix something that is not working alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 23, 2024
@georgemccabe georgemccabe added this to the METplus-5.1.1 Bugfix milestone Oct 23, 2024
@georgemccabe georgemccabe self-assigned this Oct 23, 2024
@georgemccabe georgemccabe added priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Oct 29, 2024
georgemccabe added a commit that referenced this issue Oct 30, 2024
…st_level and obs_level to match actual MET config variable names. Added unit tests to ensure correct behavior occurs
georgemccabe added a commit that referenced this issue Oct 30, 2024
…instead of fcst_level and obs_level to match actual MET config variable names. Added unit tests to ensure correct behavior occurs
@georgemccabe georgemccabe removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: bug Fix something that is not working
Projects
Status: 🏁 Done
1 participant