Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: immediately flush data to client for event-stream response #3375

Merged
merged 8 commits into from
Jul 29, 2024

Merge branch 'main' into proxy-event-stream

3ddf3e8
Select commit
Loading
Failed to load commit list.
Merged

fix: immediately flush data to client for event-stream response #3375

Merge branch 'main' into proxy-event-stream
3ddf3e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 25, 2024 in 0s

52.76% (target 49.00%)

View this Pull Request on Codecov

52.76% (target 49.00%)

Details

Codecov Report

Attention: Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.76%. Comparing base (29ab308) to head (3ddf3e8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3375      +/-   ##
==========================================
+ Coverage   52.64%   52.76%   +0.11%     
==========================================
  Files         192      193       +1     
  Lines       20439    20485      +46     
==========================================
+ Hits        10761    10808      +47     
+ Misses       8877     8869       -8     
- Partials      801      808       +7     
Files Coverage Δ
client/daemon/proxy/proxy.go 21.53% <84.21%> (+6.24%) ⬆️
client/daemon/proxy/proxy_writter.go 64.28% <64.28%> (ø)

... and 3 files with indirect coverage changes