fix: immediately flush data to client for event-stream response #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mchtech <[email protected]>
Signed-off-by: mchtech <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3375 +/- ##
==========================================
+ Coverage 52.64% 52.76% +0.11%
==========================================
Files 192 193 +1
Lines 20439 20485 +46
==========================================
+ Hits 10761 10808 +47
+ Misses 8877 8869 -8
- Partials 801 808 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: mchtech <[email protected]>
Signed-off-by: mchtech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When content type is
text/event-stream,proxy.handleHTTPshould flush data to client immediately.Related Issue
Fix #3386
same reason: golang/go#2012
Motivation and Context
MinIO client support watching and synchronizing changes from MinIO server to local fs.
It makes a "watch" request to minio server and waits server to push events when objects changed. (server also periodicly send events to client to keep connection alive, even if watched objects are not changed.)
export http_proxy=http://127.0.0.1:65001 mc mirror --watch --overwrite --debug [alias]/[bucket]/[watched-path]/ /path/to/local/When using
dfdaemonas a http proxy, MinIO client cannot receive event fromdfdaemonimmediately, ultil server pushes enough data to buffer.This patch can make MinIO client watch feature to work as expected and then download objects via dragonfly P2P network.
Related codes are copied from golang standard library.
Screenshots (if appropriate)
Types of changes
Checklist