Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Alpine 3.20 #425

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

tianon
Copy link
Member

@tianon tianon commented Dec 9, 2024

I wanted to go to Alpine 3.21, but that's not supported by Node.js 18 (ATM?)

@@ -1,6 +1,6 @@
# https://docs.ghost.org/faq/node-versions/
# https://github.com/nodejs/Release (looking for "LTS")
FROM node:18-alpine3.19
FROM node:18-alpine3.20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following those two links, should we bump the node version to 20? It is the "recommended" version from Ghost and 18 will be end of life at the end of April 2025. So, something to think about before April.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#414 😭

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It's probably worth trying a variant of that which is just the version bump, not touching libvips)

@yosifkit yosifkit merged commit 14534b9 into docker-library:master Dec 10, 2024
3 checks passed
@yosifkit yosifkit deleted the alpine3.20 branch December 10, 2024 00:36
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 10, 2024
Changes:

- docker-library/ghost@14534b9: Merge pull request docker-library/ghost#425 from infosiftr/alpine3.20
- docker-library/ghost@de8d933: Update to Alpine 3.20
- docker-library/ghost@0bbaeca: Update to 5.104.1, ghost-cli 1.26.1
- docker-library/ghost@612ee7b: Update to 5.104.0, ghost-cli 1.26.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants