Update Dockerfile base image alpine3.20->alpine3.21 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Dockerfile base image alpine3.20->alpine3.21
|
@tianon or @yosifkit may have to confirm here - but the reason alpine wasn't updated to 3.21 originally is because node 18 doesn't work with it, and there are issues updating to node 20 on some architectures. See #425. Those reasons may not be valid anymore, but either way I think updating to latest alpine is a bit more complicated than just updating the base image |
Builds and starts OK |
|
@acburdine from what I understand, the issues are with updating the node version, not the alpine version that node uses. It seems the alpine version was just a timing thing. |
|
Our So, I'm comfortable with this if you are, @acburdine ❤️ |
|
it's fine with me, just wanted to make sure there wasn't some build issue with less common arch's 👍🏻 |
acburdine
approved these changes
Jan 7, 2025
|
Let's merge it and find out! 😄 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 8, 2025
Changes: - docker-library/ghost@51d8f68: Merge pull request docker-library/ghost#428 from locohamster/master - docker-library/ghost@ecd5118: Merge pull request docker-library/ghost#1 from locohamster/update-to-alpine3.21 - docker-library/ghost@53b2329: Update Dockerfile base image alpine3.20->alpine3.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a base image bump to the latest. I was looking on the security scans of the image and there a quite few. I'm providing this version bump and trying to investigate how to resolve serious ones.