DEV: Migrate link_sections and links to new objects setting type
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
migrate_settings
branch
2 times, most recently
from
62031a7 to
7ee9aa8
Compare
tgxworld
commented
Apr 9, 2024
Comment on lines
164
to
177
| link_sections: "Design, Get inspired!|Code, Learn new things!", | ||
| links: |
There was a problem hiding this comment.
I'm not deleting the settings so that we have a way to recover should this massive migration goes wrong.
tgxworld
force-pushed
the
migrate_settings
branch
3 times, most recently
from
81dd656 to
1c0b717
Compare
tgxworld
force-pushed
the
migrate_settings
branch
3 times, most recently
from
4df2f7a to
bfcfcc9
Compare
|
Rerunning failed test.. |
tgxworld
force-pushed
the
migrate_settings
branch
from
bfcfcc9 to
e9de9d8
Compare
Oops there is a typo as a result of a rebase I did. Has been fixed now. |
nattsw
reviewed
Apr 24, 2024
nattsw
reviewed
Apr 24, 2024
nattsw
approved these changes
Apr 24, 2024
This commit migrates the `link_sections` and `links` setting to a `sections` objects typed settting. Since discourse/discourse@a440e15, we have started to support objects typed theme setting so we are switching this theme component to use it instead as it provides a much better UX for configuring the settings required for the theme component.
tgxworld
force-pushed
the
migrate_settings
branch
from
e9de9d8 to
d9c990a
Compare
|
Thank you for the review @nattsw 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the
link_sectionsandlinkssetting to asectionsobjects typed settting. Since discourse/discourse@a440e15, we have started to support objects typed theme setting so we are switching this theme component to use it instead as it provides a much better UX for configuring the settings required for the theme component.