DEV: migrate deprecated icon names in settings and update banner_links to objects schema #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to objects schema
tyb-talks
force-pushed
the
dev-migrate-deprecated-icon-names-in-settings
branch
from
4af0f75 to
e3eb1bd
Compare
tyb-talks
commented
Dec 27, 2024
Comment on lines
+6
to
+7
| icon: convertIconName(link.icon), | ||
| text: link.text.substring(0, 1000), |
There was a problem hiding this comment.
No null checks on these since the previous json schema already has minLength: 1 validations.
tgxworld
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates deprecated Font Awesome icon names saved in settings. For more detail, refer to the announcement at https://meta.discourse.org/t/-/325349.
The migration function is intentionally copying the same type of operations in https://github.com/discourse/discourse/blob/435fbb74082e1d060f97267a62dfa29c73979127/lib/svg_sprite.rb#L519 as that's used to convert the icon names in core.
This also includes a migration of the
banner_linkssetting from json schema to objects typed setting (see discourse/Discourse-easy-footer#45 for another example of a similar links setting migration).Testing
Migration worked for settings that were in json-schema.
