Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle enable_beta_ecosystems boolean setting #11334

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Jan 17, 2025

What are you trying to accomplish?

We want to use the enable_beta_ecosystems boolean in dependabot.yml files. We are not currently doing anything with this setting.

This PR will handle and use the enable_beta_ecosystems boolean in the dependabot.yml files and allow us to test with the dry-run script.

Contributes to #6528

Anything you want to highlight for special attention from reviewers?

This is a light touch approach using the existing method of passing experiments through.

How will you know you've accomplished your goal?

Bun updates should be processed when this setting is enabled.

We can test the dry run with:

./bin/dry-run.rb npm_and_yarn dsp-testing/dependabot-bun-public --enable-beta-ecosystems

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner January 17, 2025 16:19
@markhallen markhallen force-pushed the markhallen/handle-enable-beta-ecosystems branch from 2fec87b to f3427a3 Compare January 17, 2025 16:27
@markhallen markhallen changed the title Handle enable_beta_ecosystems boolean Handle enable_beta_ecosystems boolean setting Jan 17, 2025
@markhallen markhallen force-pushed the markhallen/handle-enable-beta-ecosystems branch from f3427a3 to aef668a Compare January 17, 2025 16:37
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markhallen markhallen merged commit 50db850 into main Jan 20, 2025
128 checks passed
@markhallen markhallen deleted the markhallen/handle-enable-beta-ecosystems branch January 20, 2025 12:58
@sebastianbuechler sebastianbuechler mentioned this pull request Jan 23, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants