Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of the enable_beta_ecosystems experiment #11371

Merged

Conversation

markhallen
Copy link
Contributor

@markhallen markhallen commented Jan 22, 2025

What are you trying to accomplish?

The previous implementation was incorrect. This PR correctly sets the :enable_beta_ecosystems experiment state. We are also removing the more specific :bun_updates feature as it is now redundant.

This is a follow-up/fix for Handle enable_beta_ecosystems boolean setting #11334

How will you know you've accomplished your goal?

./bin/docker-dev-shell npm_and_yarn --rebuild
./bin/dry-run.rb npm_and_yarn dsp-testing/dependabot-bun-public --enable-beta-ecosystems
Expected output
 => bump @types/bun from 1.1.16 to 1.1.18

    ± bun.lock
    ~~~
    --- /tmp/original20250122-2574-6rmd3r       2025-01-22 11:34:43.796832648 +0000
    +++ /tmp/updated20250122-2574-1wx5kf        2025-01-22 11:34:43.796832648 +0000
    @@ -2,10 +2,9 @@
       "lockfileVersion": 0,
       "workspaces": {
         "": {
    -      "name": "minimal-dependabot-bun",
           "dependencies": {
             "express": "^4.21.2",
    -        "lodash": "4.17.20",
    +        "lodash": "^4.17.21",
           },
           "devDependencies": {
             "@types/bun": "latest",
    @@ -16,7 +15,7 @@
         },
       },
       "packages": {
    -    "@types/bun": ["@types/[email protected]", "", { "dependencies": { "bun-types": "1.1.43" } }, "sha512-E+ue6NMcn4FXC5bDRE1W/BXUVs01h5Mt02qH8/8HGCox9akuh8KNOFdwvaQS9TDgT2RmUyJYFRRqA60WtTnm2g=="],
    +    "@types/bun": ["@types/[email protected]", "", { "dependencies": { "bun-types": "1.1.44" } }, "sha512-gtw6cIv/8Q530D0BmoYnjEzR65SjVq2SaUE0NeU6tbm7QBMsTZ61/NBNERtK/FUJaoi7PiteUohK7JcrXBCkvw=="],
     
         "@types/node": ["@types/[email protected]", "", { "dependencies": { "undici-types": "~5.26.4" } }, "sha512-scnD59RpYD91xngrQQLGkE+6UrHUPzeKZWhhjBSa3HSkwjbQc38+q3RoIVEwxQGRw3M+j5hpNAM+lgV3cVormg=="],
     
    @@ -28,7 +27,7 @@
     
         "body-parser": ["[email protected]", "", { "dependencies": { "bytes": "3.1.2", "content-type": "~1.0.5", "debug": "2.6.9", "depd": "2.0.0", "destroy": "1.2.0", "http-errors": "2.0.0", "iconv-lite": "0.4.24", "on-finished": "2.4.1", "qs": "6.13.0", "raw-body": "2.5.2", "type-is": "~1.6.18", "unpipe": "1.0.0" } }, "sha512-7rAxByjUMqQ3/bHJy7D6OGXvx/MMc4IqBn/X0fcM1QUcAItpZrBEYhWGem+tzXH90c+G01ypMcYJBO9Y30203g=="],
     
    -    "bun-types": ["[email protected]", "", { "dependencies": { "@types/node": "~20.12.8", "@types/ws": "~8.5.10" } }, "sha512-W0wCtVH+bwFp7p3Zgs03CqxEDmXxEvmmUM/FBKgWIv9T8gyeotvIjIbHzuDScc2DphhRNtr7hJLCR5PspYL5qw=="],
    +    "bun-types": ["[email protected]", "", { "dependencies": { "@types/node": "~20.12.8", "@types/ws": "~8.5.10" } }, "sha512-jtcekoZeSINgEcHSISzhR13w/cyE+Fankw2Cpl4c0fN3lRmKVAX0i9ay4FyK4lOxUK1HG4HkuIlrPvXKz4Y7sw=="],
     
         "bytes": ["[email protected]", "", {}, "sha512-/Nf7TyzTx6S3yRJObOAV7956r8cr2+Oj8AC5dt8wSP3BQAoeX58NoHyCU8P8zGkNXStjTSi6fzO6F0pBdcYbEg=="],
     
    @@ -94,7 +93,7 @@
     
         "ipaddr.js": ["[email protected]", "", {}, "sha512-0KI/607xoxSToH7GjN1FfSbLoU0+btTicjsQSWQlh/hZykN8KpmMf7uYwPW3R+akZ6R/w18ZlXSHBYXiYUPO3g=="],
     
    -    "lodash": ["[email protected]", "", {}, "sha512-PlhdFcillOINfeV7Ni6oF1TAEayyZBoZ8bcshTHqOYJYlrqzRK5hagpagky5o4HfCzzd1TRkXPMFq6cKk9rGmA=="],
    +    "lodash": ["[email protected]", "", {}, "sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg=="],
     
         "math-intrinsics": ["[email protected]", "", {}, "sha512-/IXtbwEk5HTPyEwyKX6hGkYXxM9nbj64B+ilVJnC/R6B0pH5G4V3b0pVbL7DBj4tkhBAppbQUlf6F6Xl9LHu1g=="],
     
    ~~~
    5 insertions (+), 6 deletions (-)

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@markhallen markhallen requested a review from a team as a code owner January 22, 2025 11:37
@markhallen markhallen force-pushed the markhallen/update-use-of-enable-beta-ecosystems-experiment branch from 06c33b3 to 3dd6ef3 Compare January 22, 2025 13:00
@markhallen markhallen force-pushed the markhallen/update-use-of-enable-beta-ecosystems-experiment branch from 3dd6ef3 to ee6a8e0 Compare January 22, 2025 13:01
@markhallen markhallen merged commit 6c55fb0 into main Jan 22, 2025
130 checks passed
@markhallen markhallen deleted the markhallen/update-use-of-enable-beta-ecosystems-experiment branch January 22, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants