Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work be1 stuart fix query already answered #1753

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

sgueissa
Copy link
Collaborator

the SetQueryReceived function now doesn't return an error when receiving more than once an answer to one of its query and just logs it.

the Test_Handle_Answer test has also been fix to work with this bug fix.

@sgueissa sgueissa added be1-go bug-fix Fixes a bug labels Feb 24, 2024
@sgueissa sgueissa self-assigned this Feb 24, 2024
@sgueissa sgueissa requested a review from a team as a code owner February 24, 2024 10:15
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇
5
▀▀▀▀▀▀
6d 7h 35m
▀▀▀▀▀▀
10
▀▀▀▀▀▀▀▀▀▀
jbsv
🥈
2
▀▀
1d 7h 33m
0
MariemBaccari
🥉
1
3d 54m
▀▀▀
0
K1li4nL
1
18m
0

Copy link
Contributor

@emonnin-epfl emonnin-epfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good except one minor thing.

be1-go/hub/standard_hub/mod_test.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 24, 2024

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@MariemBaccari MariemBaccari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sgueissa sgueissa merged commit 9153c53 into master Feb 26, 2024
18 checks passed
@sgueissa sgueissa deleted the work-be1-stuart-fix-query-already-answered branch February 26, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Idempotency when receiving the answer to a query that has already been answered
4 participants