Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Idempotency when receiving the answer to a query that has already been answered #1709

Closed
2 of 6 tasks
MariemBaccari opened this issue Nov 4, 2023 · 0 comments · Fixed by #1753
Closed
2 of 6 tasks
Assignees
Labels
be1-go bug Something isn't working decentralized Decentralized Communication Project good first issue Good for newcomers

Comments

@MariemBaccari
Copy link
Contributor

MariemBaccari commented Nov 4, 2023

Description (Actual behavior)

Currently, when we receive the answer to a query twice, we return an error to the peer the second time.

Expected behavior

This is not useful since the peers only log the errors they receive and we don't expect anything in return. It is enough to log it.

How to reproduce

This issue was first discussed in #1694

Front-ends:
  • Fe1-Web (please include browser's names & version)
  • Fe2-Android (please specify if phone or emulation, and Android version)
  • Not applicable
Back-ends:
  • Be1-Go
  • Be2-Scala
  • Not applicable

Impact

This doesn't cause any issue, at least between two go servers, as they just log the errors that they receive.

Possible root cause

The error originates from the Queries.go SetQueryReceived function and propagates all the way to the socket. We should log the error instead of sending it back.

@MariemBaccari MariemBaccari added bug Something isn't working good first issue Good for newcomers be1-go decentralized Decentralized Communication Project labels Nov 4, 2023
@sgueissa sgueissa self-assigned this Feb 21, 2024
@sgueissa sgueissa linked a pull request Feb 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
be1-go bug Something isn't working decentralized Decentralized Communication Project good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants