Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auth.ts to support "@azure/msal-browser": "^3.1.0" #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update auth.ts to support "@azure/msal-browser": "^3.1.0" #2

wants to merge 6 commits into from

Commits on Sep 25, 2023

  1. Update auth.ts to support "@azure/msal-browser": "^3.1.0" 

    See here for more info:

https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/errors.md#native_broker_called_before_initialize

I tried to add the line after
// start msal
and before
await msal.andleRedirectPromise()
but that didn't work with me, so I added it after 
export const msal = new ...
and that did work fine.

Please review as I am not 100% sure if this is correct.
I'm also not using TS.
    @iamexe
    iamexe authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1229707 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from iamexe/msal-browser-3.1.0-support 

    Update auth.ts to support "@azure/msal-browser": "^3.1.0"
    @iamexe
    iamexe authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    11c5753 View commit details
    Browse the repository at this point in the history

  3. No TypeScript Version 

    A folder containing a No TypeScript Version with a Dashboard instead of User view. Intended for a missing Express.js backend but it has local sample data.

Co-Authored-By: Dave Stewart <[email protected]>
    @iamexe @davestewart
    iamexe and davestewart committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7c30e24 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Cleanup structure.

    @iamexe
    iamexe committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f014ad1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from iamexe/Pure-JS-(no-TypeScript)-version 

    Cleanup structure.
    @iamexe
    iamexe authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a448b61 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #3 from iamexe/No-TypeScript-Version 

    No type script version
    @iamexe
    iamexe authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    614ce92 View commit details
    Browse the repository at this point in the history